[startup.c] missing `__NO_RETURN` in `Default_Handler` declaration

[tarek-bochkati]

In the proposed C startup template:

both Reset_Handler and Default_Handler prototypes have the __NO_RETURN attribute

CMSIS_6/CMSIS/Core/Template/Device_M/Source/startup_Device.c

Lines 42 to 46 in cc94f66

	/*---------------------------------------------------------------------------
	Internal References
	*---------------------------------------------------------------------------*/
	__NO_RETURN void Reset_Handler (void);
	__NO_RETURN void Default_Handler(void);

but when implemented only the Reset_Handler still showcase the __NO_RETURN attribute

CMSIS_6/CMSIS/Core/Template/Device_M/Source/startup_Device.c

Lines 110 to 114 in cc94f66

	/*---------------------------------------------------------------------------
	Reset Handler called on controller reset
	*---------------------------------------------------------------------------*/
	__NO_RETURN void Reset_Handler(void)
	{

the Default_Handler is without __NO_RETURN attribute

CMSIS_6/CMSIS/Core/Template/Device_M/Source/startup_Device.c

Lines 144 to 148 in cc94f66

	/*---------------------------------------------------------------------------
	Default Handler for Exceptions / Interrupts
	*---------------------------------------------------------------------------*/
	void Default_Handler(void)
	{

is this what it was intended to be, or __NO_RETURN attribute is just missing ?

[JonatanAntoni]

Hi @tarek-bochkati,

This seems to be an oversight to me. While the RESET_HANDLER actually never returns the DEFAULT_HANDLER is used as a regular interrupt handler. Even if the implementation does not return, an interrupt handler typically would. Thus, we've removed the NO_RETURN on the DEFAULT_HANDLER in our own implementations such as the Cortex_DFP, e.g., see https://github.com/ARM-software/Cortex_DFP/blob/36d0d3b118ab8493865044551d05248a5fe53427/Device/ARMCM3/Source/startup_ARMCM3.c#L42.

[tarek-bochkati]

Hi @JonatanAntoni

Thank you for your prompt response.
Thus do you think it would be better to remove the no return attribute from the defaut handler prototype here as well?

[JonatanAntoni]

Hi @tarek-bochkati,

Yes, we should update template to be in sync.