Skip to content

Issue #264: cmsis_iccarm.h prototype fix#265

Merged
JonatanAntoni merged 1 commit into
ARM-software:mainfrom
mhepeyiler:issue-264-iar-correct-prototypes
Oct 23, 2025
Merged

Issue #264: cmsis_iccarm.h prototype fix#265
JonatanAntoni merged 1 commit into
ARM-software:mainfrom
mhepeyiler:issue-264-iar-correct-prototypes

Conversation

@mhepeyiler

Copy link
Copy Markdown
Contributor

The fix for issue#264. void keyword is added as a function argument.

Signed-off-by: Murat Hepeyiler <murat.hepeyiler@iar.com>
@JonatanAntoni JonatanAntoni requested a review from Copilot October 23, 2025 08:55

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses issue #264 by adding explicit void parameters to function prototypes in the CMSIS ICCARM header file. The changes improve C standard compliance by converting empty parameter lists to explicitly parameterless functions.

  • Updated three function prototypes to include explicit void parameters
  • Affects __CLREX(), __disable_fault_irq(), and __enable_fault_irq() functions
  • Improves code clarity and standards compliance

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@JonatanAntoni

Copy link
Copy Markdown
Member

Looks fine to me.
@RobinKastberg, please cross check.

@github-actions

Copy link
Copy Markdown

Test Results

   264 files   -   108     264 suites   - 108   0s ⏱️ - 9m 2s
    56 tests +    7      54 ✅ + 10      2 💤  -     3  0 ❌ ±0 
14 292 runs   - 3 936  12 124 ✅ +160  2 168 💤  - 4 096  0 ❌ ±0 

Results for commit f663ed0. ± Comparison against base commit 0a30407.

This pull request removes 49 and adds 56 tests. Note that renamed tests count towards both.
CMSIS-Core.src ‑ apsr.c
CMSIS-Core.src ‑ basepri.c
CMSIS-Core.src ‑ bkpt.c
CMSIS-Core.src ‑ clrex.c
CMSIS-Core.src ‑ clz.c
CMSIS-Core.src ‑ control.c
CMSIS-Core.src ‑ cp15.c
CMSIS-Core.src ‑ cpsr.c
CMSIS-Core.src ‑ dmb.c
CMSIS-Core.src ‑ dsb.c
…
TC_CML1Cache_CleanDCacheByAddrWhileDisabled
TC_CML1Cache_EnDisableDCache
TC_CML1Cache_EnDisableICache
TC_CoreFunc_APSR
TC_CoreFunc_BASEPRI
TC_CoreFunc_Control
TC_CoreFunc_EnDisIRQ
TC_CoreFunc_EncDecIRQPrio
TC_CoreFunc_FAULTMASK
TC_CoreFunc_FPSCR
…
This pull request removes 5 skipped tests and adds 2 skipped tests. Note that renamed tests count towards both.
CMSIS-Core.src ‑ lda.c
CMSIS-Core.src ‑ ldaex.c
CMSIS-Core.src ‑ stl.c
CMSIS-Core.src ‑ stlex.c
CMSIS-Core.src ‑ systick.c
TC_CoreInstr_WFE
TC_CoreInstr_WFI

@RobinKastberg

Copy link
Copy Markdown
Contributor

LGTM

@JonatanAntoni JonatanAntoni merged commit 671eba9 into ARM-software:main Oct 23, 2025
8 checks passed
@mhepeyiler mhepeyiler deleted the issue-264-iar-correct-prototypes branch October 23, 2025 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants