Issue #264: cmsis_iccarm.h prototype fix#265
Merged
JonatanAntoni merged 1 commit intoOct 23, 2025
Merged
Conversation
Signed-off-by: Murat Hepeyiler <murat.hepeyiler@iar.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses issue #264 by adding explicit void parameters to function prototypes in the CMSIS ICCARM header file. The changes improve C standard compliance by converting empty parameter lists to explicitly parameterless functions.
- Updated three function prototypes to include explicit
voidparameters - Affects
__CLREX(),__disable_fault_irq(), and__enable_fault_irq()functions - Improves code clarity and standards compliance
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Member
|
Looks fine to me. |
Test Results 264 files - 108 264 suites - 108 0s ⏱️ - 9m 2s Results for commit f663ed0. ± Comparison against base commit 0a30407. This pull request removes 49 and adds 56 tests. Note that renamed tests count towards both.This pull request removes 5 skipped tests and adds 2 skipped tests. Note that renamed tests count towards both. |
Contributor
|
LGTM |
JonatanAntoni
approved these changes
Oct 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fix for issue#264. void keyword is added as a function argument.