✨ Extend the code generator for Collections by extending their functionality to follow links#76
Merged
✨ Extend the code generator for Collections by extending their functionality to follow links#76
Conversation
acabarbaye
reviewed
Mar 28, 2025
acabarbaye
reviewed
Mar 28, 2025
acabarbaye
reviewed
Mar 28, 2025
acabarbaye
reviewed
Mar 28, 2025
acabarbaye
reviewed
Mar 28, 2025
acabarbaye
reviewed
Mar 28, 2025
aorabdel
force-pushed
the
client_generator
branch
2 times, most recently
from
0e6f528 to
5f59ae1
Compare
aorabdel
force-pushed
the
client_generator
branch
from
5f59ae1 to
4dd5855
Compare
Bumps golang from 1.23.5 to 1.24.1. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) You can trigger a rebase of this PR by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Monty Bot <monty-bot@arm.com> Co-authored-by: Adrien CABARBAYE <adrien.cabarbaye@arm.com> Co-authored-by: acabarbaye <acabarbaye@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
we need to stop the CI from doing this on every commit
joshjennings98
approved these changes
Mar 31, 2025
Contributor
joshjennings98
left a comment
joshjennings98
left a comment
There was a problem hiding this comment.
This looks better, thanks for addressing my comments 👍
acabarbaye
approved these changes
Mar 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change extends the generator for endpoints with a
Getmethod that returns aCollection(x-collectionor SimpleCollection schemas), and defines two methods for following links for each endpoint, one in the APIService struct and one in the APIRequest struct.The generation is based on the same methods that executes a Get request, the original Execute method is parsed into an AST, copied and modified to be able to follow links, by adding a link argument, and modifying the path to follow that argument.
Test Coverage
The test added only tests generation for the FollowLinks functions as the testing for
x-redactin Collections is already part of existing tests.