💚 linting

Author: acabarbaye

utils/maps/flatten.go

@@ -121,7 +121,7 @@ func flattenMap(result Map, prefix string, v reflect.Value) (err error) {
 }
 
 func flattenSlice(result Map, prefix string, v reflect.Value) (err error) {
-	prefix = prefix + separator
+	prefix += separator
 
 	for i := 0; i < v.Len(); i++ {
 		subErr := flatten(result, fmt.Sprintf("%s%d", prefix, i), v.Index(i))
@@ -134,7 +134,7 @@ func flattenSlice(result Map, prefix string, v reflect.Value) (err error) {
 }
 
 func flattenStruct(result Map, prefix string, v reflect.Value) (err error) {
-	prefix = prefix + separator
+	prefix += separator
 	ty := v.Type()
 	for i := 0; i < ty.NumField(); i++ {
 		subErr := flatten(result, fmt.Sprintf("%s%s", prefix, ty.Field(i).Name), v.Field(i))

utils/maps/flatten_test.go

@@ -204,7 +204,7 @@ func TestFlatten2(t *testing.T) {
 				},
 			},
 			Output: map[string]string{
-				"foo.SomeDuration": time.Duration(56 * time.Minute).String(),
+				"foo.SomeDuration": (56 * time.Minute).String(),
 			},
 		},
 	}

utils/maps/map.go

@@ -31,7 +31,7 @@ func (m Map) AsMap() map[string]string {
 
 // Delete deletes a key out of the maps with the given prefix.
 func (m Map) Delete(prefix string) {
-	for k, _ := range m {
+	for k := range m {
 		match := k == prefix
 		if !match {
 			if !strings.HasPrefix(k, prefix) {
@@ -50,7 +50,7 @@ func (m Map) Delete(prefix string) {
 // Keys returns all the top-level keys in this maps
 func (m Map) Keys() []string {
 	ks := make(map[string]struct{})
-	for k, _ := range m {
+	for k := range m {
 		idx := strings.Index(k, separator)
 		if idx == -1 {
 			idx = len(k)
@@ -60,7 +60,7 @@ func (m Map) Keys() []string {
 	}
 
 	result := make([]string, 0, len(ks))
-	for k, _ := range ks {
+	for k := range ks {
 		result = append(result, k)
 	}
 

utils/serialization/maps/map.go

@@ -112,21 +112,6 @@ func toTime(f reflect.Type, t reflect.Type, data any) (any, error) {
 	}
 }
 
-func fromTimeDurationHookFunc() mapstructure.DecodeHookFunc {
-	return func(
-		f reflect.Type,
-		t reflect.Type,
-		data any,
-	) (any, error) {
-		switch f {
-		case reflect.TypeOf(time.Duration(5)):
-			return convertTo(f.String(), data, t)
-		default:
-			return data, nil
-		}
-	}
-}
-
 func mapstructureDecoder(input, result any) error {
 	decoder, err := mapstructure.NewDecoder(&mapstructure.DecoderConfig{
 		WeaklyTypedInput: true,

utils/serialization/slice/slice.go

@@ -3,7 +3,7 @@ package slice
 import (
 	"github.com/ARM-software/golang-utils/utils/collection"
 	"github.com/ARM-software/golang-utils/utils/commonerrors"
-	"github.com/ARM-software/golang-utils/utils/serialization/maps"
+	"github.com/ARM-software/golang-utils/utils/serialization/maps" //nolint:misspell
 )
 
 // ToSlice converts a struct to a list of key values.