Fix pytests

Author: zuorenchen

rocketpy/rocket/aero_surface/linear_generic_surface.py

@@ -169,7 +169,7 @@ def __init__(
         # Populate the coefficients from the list of constants if they are not defined
         if coefficients is None:
             coefficients = self._get_default_coefficients()
-        if coefficient_constants is not None:
+        if coefficient_constants:
             assert len(coefficient_constants) == len(
                 self._get_default_coefficients()
             ), (

tests/unit/sensors/test_sensor.py

@@ -381,70 +381,35 @@ def test_noisy_barometer(noisy_barometer, example_plain_env):
 
 def test_noisy_gnss(noisy_gnss, example_plain_env):
     """Test the measure method of the GnssReceiver class. Checks if saved
-    measurement is (latitude, longitude, altitude) and if measured_data is [(t, (latitude, longitude, altitude)), ...]
+    measurement is (x, y, z, vx, vy, vz) and if measured_data is [(t, x, y, z, vx, vy, vz), ...]
     """
     # expected measurement without noise
     relative_position = Vector([0.4, 0.4, 1])
-    lat, lon = example_plain_env.latitude, example_plain_env.longitude
-    earth_radius = example_plain_env.earth_radius
     x, y, z = (Matrix.transformation(U[6:10]) @ relative_position) + Vector(U[0:3])
-    drift = (x**2 + y**2) ** 0.5
-    bearing = (2 * np.pi - np.arctan2(-x, y)) * (180 / np.pi)
-    latitude = np.degrees(
-        np.arcsin(
-            np.sin(np.radians(lat)) * np.cos(drift / earth_radius)
-            + np.cos(np.radians(lat))
-            * np.sin(drift / earth_radius)
-            * np.cos(np.radians(bearing))
-        )
-    )
-    longitude = np.degrees(
-        np.radians(lon)
-        + np.arctan2(
-            np.sin(np.radians(bearing))
-            * np.sin(drift / earth_radius)
-            * np.cos(np.radians(lat)),
-            np.cos(drift / earth_radius)
-            - np.sin(np.radians(lat)) * np.sin(np.radians(latitude)),
-        )
-    )
-    altitude = z
+    vx, vy, vz = (
+        Matrix.transformation(U[6:10])
+        @ Vector.cross(Vector(U[10:13]), relative_position)
+    ) + Vector(U[3:6])
 
     noisy_gnss.measure(
         time=TIME,
         u=U,
         relative_position=relative_position,
         environment=example_plain_env,
     )
-    assert noisy_gnss.measurement == approx([latitude, longitude, altitude], abs=3.2)
-    assert len(noisy_gnss.measurement) == 3
-    assert noisy_gnss.measured_data[0][1:] == approx(
-        [latitude, longitude, altitude], abs=3.2
-    )
+    assert noisy_gnss.measurement == approx([x, y, z, vx, vy, vz], abs=3.0)
+    assert len(noisy_gnss.measurement) == 6
+    assert noisy_gnss.measured_data[0][1:] == approx([x, y, z, vx, vy, vz], abs=3.0)
     assert noisy_gnss.measured_data[0][0] == TIME
 
-    # check last measurement considering noise error bounds
-    noisy_gnss.measure(
-        time=TIME,
-        u=U,
-        relative_position=relative_position,
-        environment=example_plain_env,
-    )
-    assert noisy_gnss.measurement == approx([latitude, longitude, altitude], abs=3.2)
-    assert len(noisy_gnss.measurement) == 3
-    assert noisy_gnss.measured_data[1][1:] == approx(
-        [latitude, longitude, altitude], abs=3.2
-    )
-    assert noisy_gnss.measured_data[1][0] == TIME
-
 
 @pytest.mark.parametrize(
     "sensor, file_format, expected_header",
     [
         ("ideal_accelerometer", "csv", "t,ax,ay,az\n"),
         ("ideal_gyroscope", "csv", "t,wx,wy,wz\n"),
         ("ideal_barometer", "csv", "t,pressure\n"),
-        ("ideal_gnss", "csv", "t,latitude,longitude,altitude\n"),
+        ("ideal_gnss", "csv", "t,x,y,z,vx,vy,vz\n"),
     ],
 )
 def test_export_data_csv(
@@ -485,7 +450,7 @@ def test_export_data_csv(
         ("ideal_accelerometer", "json", ("ax", "ay", "az")),
         ("ideal_gyroscope", "json", ("wx", "wy", "wz")),
         ("ideal_barometer", "json", ("pressure",)),
-        ("ideal_gnss", "json", ("latitude", "longitude", "altitude")),
+        ("ideal_gnss", "json", ("x", "y", "z", "vx", "vy", "vz")),
     ],
 )
 def test_export_data_json(

tests/unit/simulation/test_flight.py

@@ -210,7 +210,7 @@ def test_export_sensor_data(flight_calisto_with_sensors):
 @pytest.mark.parametrize(
     "flight_time, expected_values",
     [
-        ("t_initial", (0.25886, -0.649623, 0)),
+        ("t_initial", (0.05072660158631715, -0.12730092240875748, 0)),
         ("out_of_rail_time", (0.792028, -1.987634, 0)),
         ("apogee_time", (-0.509420, -0.732933, -2.089120e-14)),
         ("t_final", (0, 0, 0)),
@@ -249,7 +249,7 @@ def test_aerodynamic_moments(flight_calisto_custom_wind, flight_time, expected_v
 @pytest.mark.parametrize(
     "flight_time, expected_values",
     [
-        ("t_initial", (1.654150, 0.659142, -0.067103)),
+        ("t_initial", (0.32414923451082056, 0.12916629952407094, -0.067103)),
         ("out_of_rail_time", (5.052628, 2.013361, -1.75370)),
         ("apogee_time", (2.321838, -1.613641, -0.962108)),
         ("t_final", (-0.019802, 0.012030, 159.051604)),