A boolean is not a rate, and an oversized int is not a different error

YAML reads `yes` and `on` as True and `float(True)` is 1.0, so
`sampling_rate: yes` became 1 Hz instead of 100 with nothing said. The previous
revision of the test file pinned that as the contract, which is worse than
leaving it unspecified. Refused now, the same way a boolean is already refused
as a range endpoint.

`float(10**400)` raises OverflowError, so one argument in the same validator
came back as a different exception type from everything beside it.

126 tests, up from 122.

Signed-off-by: thc1006 <84045975+thc1006@users.noreply.github.com>

Author: thc1006

rocketpy/rocket/actuator/actuator.py

@@ -17,10 +17,16 @@ def _finite_or_raise(value, description):
     refused, since an actuator cannot start at or be driven to one, and a value
     that is not a number at all is refused here rather than a few lines later
     inside ``np.clip``.
+
+    ``bool`` is refused with them. YAML reads ``yes`` and ``on`` as ``True``, and
+    ``float(True)`` is 1.0, so a sampling rate written that way became 1 Hz with
+    nothing said.
     """
+    if isinstance(value, bool):
+        raise ValueError(f"{description} must be a number, not a boolean.")
     try:
         number = float(value)
-    except (TypeError, ValueError) as error:
+    except (TypeError, ValueError, OverflowError) as error:
         raise ValueError(f"{description} must be a number.") from error
     if not np.isfinite(number):
         raise ValueError(f"{description} must be a finite number.")

tests/unit/rocket/test_actuators.py

@@ -797,12 +797,10 @@ def _rate_of(rocket, attribute, per_axis):
         return (actuator.x if per_axis else actuator).demand_rate
 
     @pytest.mark.parametrize("adder, attribute, extra, per_axis", ADDERS)
-    @pytest.mark.parametrize("given", ["100", True, 100])
+    @pytest.mark.parametrize("given", ["100", 100, 100.0])
     def test_both_halves_hold_the_same_normalized_value(
         self, calisto, adder, attribute, extra, per_axis, given
     ):
-        """``True`` is in here because ``float(True)`` is 1.0, so a bool reaches
-        the actuator as a rate and used to reach the controller as a bool."""
         getattr(calisto, adder)(
             controller_function=_no_op_controller, sampling_rate=given, **extra
         )
@@ -866,3 +864,25 @@ def test_an_accepted_second_call_still_replaces(self, calisto, adder, extra):
 
         assert len(calisto._controllers) == 1
         assert calisto._controllers[0].sampling_rate == 50.0
+
+
+class TestABooleanIsNotARate:
+    """YAML reads `yes` and `on` as True, and float(True) is 1.0.
+
+    A sampling rate written that way became 1 Hz with nothing said, and an
+    earlier revision of this file pinned that as the contract.
+    """
+
+    @pytest.mark.parametrize(
+        "option",
+        ["demand_rate", "throttle_rate_limit", "throttle_time_constant"],
+    )
+    def test_a_boolean_is_refused(self, option):
+        with pytest.raises(ValueError, match="boolean"):
+            ThrottleActuator(**{option: True})
+
+    def test_an_integer_too_large_for_a_float_is_a_value_error(self):
+        """`float(10**400)` raises OverflowError, so the validator leaked a
+        different exception type than everything beside it."""
+        with pytest.raises(ValueError):
+            ThrottleActuator(demand_rate=10**400)