generate new expected test data and fix tolerances

Author: MarleneBusch

artist/core/heliostat_ray_tracer.py

@@ -825,8 +825,6 @@ def sample_bitmaps(
         index_3[~intersection_indices_on_target] = 0
         index_4[~intersection_indices_on_target] = 0
 
-        # index_1 = index_1[torch.where(index_1 < 0 | index_1 > )]
-
         intensities_pixel_1 = intensities_pixel_1 * intersection_indices_on_target
         intensities_pixel_2 = intensities_pixel_2 * intersection_indices_on_target
         intensities_pixel_3 = intensities_pixel_3 * intersection_indices_on_target

tests/core/test_blocking.py

@@ -413,12 +413,6 @@ def test_blocking_integration(device: torch.device) -> None:
         device=device,
     )
 
-    # Scale bitmap for testing precision.
-    bitmaps_per_heliostat = (
-        bitmaps_per_heliostat
-        / (bitmaps_per_heliostat.sum(dim=(1, 2), keepdim=True) + 1e-8)
-    ) * 100
-
     expected_path = (
         pathlib.Path(ARTIST_ROOT)
         / "tests/data/expected_bitmaps_blocking"
@@ -427,7 +421,12 @@ def test_blocking_integration(device: torch.device) -> None:
 
     expected = torch.load(expected_path, map_location=device, weights_only=True)
 
-    torch.testing.assert_close(bitmaps_per_heliostat, expected, atol=5e-4, rtol=5e-4)
+    torch.testing.assert_close(
+        bitmaps_per_heliostat,
+        expected,
+        atol=bitmaps_per_heliostat.mean() * 0.01,
+        rtol=0.01,
+    )
 
 
 def test_ray_extinction(device: torch.device) -> None:
@@ -510,9 +509,6 @@ def test_ray_extinction(device: torch.device) -> None:
         (bitmaps_per_heliostat_no_extinction, bitmaps_per_heliostat_extinction)
     )
 
-    # Scale bitmap for testing precision.
-    bitmaps = (bitmaps / (bitmaps.sum(dim=(1, 2), keepdim=True) + 1e-8)) * 100
-
     expected_path = (
         pathlib.Path(ARTIST_ROOT)
         / "tests/data/expected_bitmaps_ray_extinction"
@@ -521,7 +517,7 @@ def test_ray_extinction(device: torch.device) -> None:
 
     expected = torch.load(expected_path, map_location=device, weights_only=True)
 
-    torch.testing.assert_close(bitmaps, expected, atol=5e-4, rtol=5e-4)
+    torch.testing.assert_close(bitmaps, expected, atol=bitmaps.mean() * 0.01, rtol=0.01)
     torch.testing.assert_close(
         bitmaps_per_heliostat_no_extinction[0].sum() * (1 - ray_extinction_factor),
         bitmaps_per_heliostat_extinction[0].sum(),