Welcome to CANVAS🌞! We're thrilled that you're interested in contributing to our open-source project 🔥.
By participating, you can help improve the project and make it even better 🙌.
-
Fork the Repository: Click the "Fork" button at the top right corner of this repository's page to create your own copy.
-
Clone Your Fork: Clone your forked repository to your local machine using Git
:git clone https://github.com/ARTIST-Association/CANVAS.git `` -
Install all development dependencies in a separate python virtual environment from the main branch of your repo. This will put a number of pre-commit hooks, for code linting and code style for both Python and JavaScript, into place. It will also install tools like ruff and ESLint, used for development. Till we completely merged to a pyproject.toml you need to run the following commands:
# Python environment python3 -m venv <insert/path/to/your/venv> source <insert/path/to/your/venv/bin/activate> # Pre commit hooks pre-commit install # Dev tools cd canvas_editor/ python -m pip install -r requirements.txt npm install
-
Create a Branch: Create a new branch for your contribution. Choose a descriptive name. Depending on what you want to work on, prepend either of the following prefixes,
features,maintenance,bugfix, orhotfix. Example:git checkout -b features/your-feature-name
-
Make Changes: Make your desired changes to the codebase. Please stick to the following guidelines:
Python:
- Please use type hints in all function definitions.
- Please use American English for all comments and docstrings in the code.
- Please use the NumPy Docstring Standard for your docstrings:
""" Short Description Long Description (if needed) Parameters ---------- param1 : type Description of param1. param2 : type, optional Description of param2. (if it's an optional argument) Returns ------- return_type Description of the return value. Raises ------ ExceptionType Description of when and why this exception might be raised. See Also -------- other_function : Related function or module. Examples -------- >>> import numpy as np >>> x = np.array([1, 2, 3]) >>> y = np.square(x) >>> print(y) array([1, 4, 9]) Notes ----- Additional notes, recommendations, or important information. """
When applicable, please make references to parent modules and classes using
:class:`ParentClassName`as shown below. Do not include attributes and methods of the parent class explicitly.class ParentClass: """ The docstring for the parent class. Attributes ---------- attribute : type Description of attribute. Methods ------- method() Description of method. """ class ChildClass(ParentClass): """ The docstring for the child class. Attributes ---------- attribute_child : type Description of attribute_child. Methods ---------- method_child() Description of method_child. See Also -------- :class:`ParentClass` : Reference to the parent class. """
In the example above,
:class:`ParentClass`is used to create a reference to the parent classParentClass.JavaScript:
- Use JsDocs for classes and functions, so that ESLint is satisfied
- Follow the guidelines specified in the
eslint.config.mjs
-
Commit Changes: Commit your changes with a clear and concise commit message that describes what you have changed. Example:
git commit -m "add rotation control for heliostat" -
Push Changes: Push your changes to your fork on GitHub:
git push origin features/your-feature-name
As the remote branch is already linked
-
Rebase Onto Current Main: Rebase your feature branch onto the current main branch of the original repo. This will include any changes that might have been pushed into the main in the meantime and resolve possible conflicts. To sync your fork with the original upstream repo, check out this page or follow the steps below. Note that before you can sync your fork with an upstream repo, you must configure a remote that points to the upstream repository in Git.
cd <path/to/your/local/project/fork> git fetch upstream git checkout main git merge upstream/main git rebase main features/your-feature-name -
Open a Pull Request: Go to the original repository and click the "New Pull Request" button. Follow the guidelines in the template to submit your pull request.
Please note that we have a Code of Conduct, and we expect all contributors to follow it. Be kind and respectful to one another 💙.
If you have questions or encounter any issues, please create an issue in the Issues section of this repository.
Thank you for your contribution 🙏!