Merge develop branch to master ready for release.

Author: Peter-Simpson

Conform/ApplicationSettings.vb

@@ -87,6 +87,8 @@ Friend Class ApplicationSettings
     'Camera device variables
     Private Const CAMERA_MAX_BIN_X As String = "Camera Max Bin X", CAMERA_MAX_BIN_X_DEFAULT As Integer = 0
     Private Const CAMERA_MAX_BIN_Y As String = "Camera Max Bin Y", CAMERA_MAX_BIN_Y_DEFAULT As Integer = 0
+    Private Const CAMERA_TEST_IMAGEARRAYVARIANT As String = "Camera Test ImageArrayVariant", CAMERA_TEST_IMAGEARRAYVARIANT_DEFAULT As Boolean = True
+
 
 #End Region
 
@@ -794,6 +796,14 @@ Friend Class ApplicationSettings
             SetName(m_SettingsKey, CAMERA_MAX_BIN_Y, value.ToString)
         End Set
     End Property
+    Property CameraTestImageArrayVariant() As Boolean
+        Get
+            Return GetBool(CAMERA_TEST_IMAGEARRAYVARIANT, CAMERA_TEST_IMAGEARRAYVARIANT_DEFAULT)
+        End Get
+        Set(ByVal value As Boolean)
+            SetName(m_SettingsKey, CAMERA_TEST_IMAGEARRAYVARIANT, value.ToString)
+        End Set
+    End Property
 
 
 #End Region

Conform/Devices/CameraTester.vb

@@ -295,6 +295,7 @@ Friend Class CoverCalibratorTester
                             LogMsg("OpenCover", MessageLevel.msgOK, $"OpenCover was successful. The synchronous open took {DateTime.Now.Subtract(startTime).TotalSeconds.ToString("0.0")} seconds")
                         Else ' Unsuccessful outcome
                             LogMsg("OpenCover", MessageLevel.msgError, $"OpenCover was unsuccessful - the returned CoverState was '{coverCalibratorDevice.CoverState.ToString().Trim()}' instead of 'Open'. The synchronous open took {DateTime.Now.Subtract(startTime).TotalSeconds.ToString("0.0")} seconds")
+                            LogMsgInfo("OpenCover", "PLEASE NOTE: The error above will also appear if your device does not set CoverState to Moving before returning from the OpenCover command.")
                         End If
                     Else ' Asynchronous behaviour
                         canAsynchronousOpen = True
@@ -343,6 +344,7 @@ Friend Class CoverCalibratorTester
                             LogMsg("CloseCover", MessageLevel.msgOK, $"CloseCover was successful. The synchronous close took {DateTime.Now.Subtract(startTime).TotalSeconds.ToString("0.0")} seconds")
                         Else ' Unsuccessful outcome
                             LogMsg("CloseCover", MessageLevel.msgError, $"CloseCover was unsuccessful - the returned CoverState was '{coverCalibratorDevice.CoverState.ToString().Trim()}' instead of 'Closed'. The synchronous close took {DateTime.Now.Subtract(startTime).TotalSeconds.ToString("0.0")} seconds")
+                            LogMsgInfo("CloseCover", "PLEASE NOTE: The error above will also appear if your device does not set CoverState to Moving before returning from the CloseCover command.")
                         End If
                     Else ' Asynchronous behaviour
                         canAsynchronousOpen = True
@@ -544,6 +546,7 @@ Friend Class CoverCalibratorTester
                                 LogMsg("CalibratorOff", MessageLevel.msgOK, $"Brightness is set to zero when the calibrator is turned off")
                             Else ' Brightness is not set to zero when the calibrator is turned off
                                 LogMsg("CalibratorOff", MessageLevel.msgIssue, $"Brightness is not set to zero when the calibrator is turned off")
+                                LogMsgInfo("CalibratorOff", "PLEASE NOTE: The issue above will also appear if your device does not set CalibratorState to NotReady before returning from the CalibratorOff command.")
                             End If
 
                         Else ' Unsuccessful outcome
@@ -621,6 +624,7 @@ Friend Class CoverCalibratorTester
                                 LogMsg("CalibratorOn", MessageLevel.msgOK, $"The Brightness property does return the value that was set")
                             Else ' The returned Brightness is different to what was set
                                 LogMsg("CalibratorOn", MessageLevel.msgIssue, $"The Brightness property value: {returnedBrightness} does not match the value that was set: {requestedBrightness}")
+                                LogMsgInfo("CalibratorOn", "PLEASE NOTE: The issue above will also appear if your device does not set CalibratorState to NotReady before returning from the CalibratorOn command.")
                             End If
 
                         Else ' Unsuccessful outcome
@@ -669,7 +673,6 @@ Friend Class CoverCalibratorTester
         End If
     End Sub
 
-
     Public Overrides Sub CheckPerformance()
         Status(StatusType.staTest, "Performance")
 

Conform/Devices/CoverCalibrator Tester.vb

@@ -32,6 +32,7 @@ Public Class frmSetup
         chkDisplayMethodCalls.Checked = g_Settings.DisplayMethodCalls
         numMaxBinX.Value = Convert.ToInt32(g_Settings.CameraMaxBinX)
         numMaxBinY.Value = Convert.ToInt32(g_Settings.CameraMaxBinY)
+        ChkTestImageArrayVariant.Checked = g_Settings.CameraTestImageArrayVariant
         txtSwitchExtendedTestRange.Text = g_Settings.ExtendedSwitchNumberTestRange
 
         If chkSetupTestSideOfPierWrite.Checked Then ' Test SideOfpier Write is enabled
@@ -165,6 +166,7 @@ Public Class frmSetup
             'Camera
             g_Settings.CameraMaxBinX = CInt(numMaxBinX.Value)
             g_Settings.CameraMaxBinY = CInt(numMaxBinY.Value)
+            g_Settings.CameraTestImageArrayVariant = ChkTestImageArrayVariant.Checked
 
             'Special - DestinationSideOfPier
             g_Settings.FlipTestHAStart(GlobalVarsAndCode.SpecialTests.TelescopeDestinationSideOfPier, PierSide.pierWest) = CDbl(txtStartHAW.Text)

Conform/FrmSetup.designer.vb

@@ -14,7 +14,7 @@ Imports System.Runtime.InteropServices
 <Assembly: AssemblyDescription("ASCOM Conformance Checker." & vbcrlf & vbcrlf & "This tool confirms conformance of an ASCOM driver to the relevant ASCOM specification." & vbcrlf & vbcrlf & "Please report issues on ASCOM's Groups.io Help forum, thanks - Peter.")> 
 <Assembly: AssemblyCompany("Peter Simpson")> 
 <Assembly: AssemblyProduct("Conform")>
-<Assembly: AssemblyCopyright("Copyright © Peter Simpson 2021")>
+<Assembly: AssemblyCopyright("Copyright © Peter Simpson 2022")>
 <Assembly: AssemblyTrademark("")> 
 
 <Assembly: ComVisible(False)> 

Conform/FrmSetup.vb

@@ -98,12 +98,12 @@ Name: "..\BuildConform.cmd"; Flags: CmdPrompt
 
 [Code]
 const
-   REQUIRED_PLATFORM_VERSION = 6.5;    // Set this to the minimum required ASCOM Platform version for this application
+   REQUIRED_PLATFORM_VERSION = 6.5; // Set this to the minimum required ASCOM Platform version for this application
 
 //
 // Function to return the ASCOM Platform's version number as a double.
 //
-function PlatformVersion(): Double;
+function PlatformVersion(): Extended;
 var
    PlatVerString : String;
 begin
@@ -133,8 +133,8 @@ var
    else
       if PlatformVersionNumber = 0.0 then
          MsgBox('No ASCOM Platform is installed. Please install Platform ' + Format('%3.1f', [REQUIRED_PLATFORM_VERSION]) + ' or later from http://www.ascom-standards.org', mbCriticalError, MB_OK)
-      else 
-         MsgBox('ASCOM Platform ' + Format('%3.1f', [REQUIRED_PLATFORM_VERSION]) + ' or later is required, but Platform '+ Format('%3.1f', [PlatformVersionNumber]) + ' is installed. Please install the latest Platform before continuing; you will find it at http://www.ascom-standards.org', mbCriticalError, MB_OK);
+      else  
+         MsgBox('This version of Conform requires ASCOM Platform ' + Format('%3.1f', [REQUIRED_PLATFORM_VERSION]) + ' or later, but Platform '+ Format('%3.1f', [PlatformVersionNumber]) + ' is installed.' #13#13 'Please install the latest Platform before continuing; you will find it at https://www.ascom-standards.org', mbCriticalError, MB_OK);
 end;
 
 // Code to enable the installer to uninstall previous versions of itself when a new version is installed