Skip to content

Commit f73ac1c

Browse files
committed
Merge develop branch in preparation for the next release.
2 parents a54d5d2 + 7b9f47a commit f73ac1c

7 files changed

Lines changed: 319 additions & 119 deletions

File tree

Conform/Devices/CameraTester.vb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -999,7 +999,7 @@ Friend Class CameraTester
999999
LogMsg("ReadoutModes Read", MessageLevel.msgOK, ReadoutMode.ToString)
10001000
Next
10011001
Catch ex As Exception
1002-
HandleException("Gain Read", MemberType.Property, Required.Mandatory, ex, "")
1002+
HandleException("ReadoutModes Read", MemberType.Property, Required.Mandatory, ex, "")
10031003
End Try
10041004

10051005
' ReadoutMode Read - Mandatory

Conform/Devices/FocuserTester.vb

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,8 @@
88
Private m_StepSize, m_Temperature As Double
99
Private m_TempCompTrueOK, m_TempCompFalseOK As Boolean ' Variable to confirm that TempComp can be successfully set to True
1010
Private m_AbsolutePositionOK As Boolean = False ' Variable to confirm that absolute position can be read OK
11+
Private m_CanReadIsMoving As Boolean = False ' Variable to confirm that IsMoving can be read OK
12+
Private m_CanReadTemperature As Boolean = False ' Variable to confirm that Temperature can be read OK
1113

1214
Private Const GOOD_MOVE_TOLERANCE As Integer = 2 ' ± Position tolerance within which a move will be considered to be OK
1315
Private Const OUT_OF_RANGE_INCREMENT As Integer = 10 ' For absolute focusers, the position delta, below 0 or above maximum steps, to test that the focuser will not move to the specified position
@@ -239,9 +241,11 @@
239241
'IsMoving - Required
240242
Try
241243
LogCallToDriver("IsMoving", "About to get IsMoving property")
244+
m_CanReadIsMoving = False
242245
m_IsMoving = m_Focuser.IsMoving
243246
If Not m_IsMoving Then
244247
LogMsg("IsMoving", MessageLevel.msgOK, m_IsMoving.ToString)
248+
m_CanReadIsMoving = True
245249
Else
246250
LogMsg("IsMoving", MessageLevel.msgError, "IsMoving is True at start of tests and it should be false")
247251
End If
@@ -373,6 +377,7 @@
373377

374378
'Temperature - Optional
375379
Try
380+
m_CanReadTemperature = False
376381
LogCallToDriver("Temperature", "About to get Temperature property")
377382
m_Temperature = m_Focuser.Temperature
378383
Select Case m_Temperature
@@ -382,6 +387,7 @@
382387
LogMsg("Temperature", MessageLevel.msgWarning, "Temperature > 50.0, - possibly an issue, actual value: " & m_Temperature.ToString)
383388
Case Else
384389
LogMsg("Temperature", MessageLevel.msgOK, m_Temperature.ToString)
390+
m_CanReadTemperature = True
385391
End Select
386392
Catch ex As Exception
387393
HandleException("Temperature", MemberType.Property, Required.Optional, ex, "")
@@ -637,21 +643,21 @@
637643

638644
Overrides Sub CheckPerformance()
639645
'Position
640-
If True Then
646+
If m_AbsolutePositionOK Then
641647
FocuserPerformanceTest(FocuserPropertyMethod.Position, "Position")
642648
Else
643649
LogMsg("Position", MessageLevel.msgInfo, "Skipping test as property is not supported")
644650
End If
645651

646652
'IsMoving
647-
If True Then
653+
If m_CanReadIsMoving Then
648654
FocuserPerformanceTest(FocuserPropertyMethod.IsMoving, "IsMoving")
649655
Else
650656
LogMsg("IsMoving", MessageLevel.msgInfo, "Skipping test as property is not supported")
651657
End If
652658

653-
'IsMoving
654-
If True Then
659+
'Temperature
660+
If m_CanReadTemperature Then
655661
FocuserPerformanceTest(FocuserPropertyMethod.Temperature, "Temperature")
656662
Else
657663
LogMsg("Temperature", MessageLevel.msgInfo, "Skipping test as property is not supported")

Conform/Devices/RotatorTester.vb

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -134,6 +134,30 @@ Friend Class RotatorTester
134134
GC.Collect()
135135
End Try
136136

137+
Try
138+
l_DeviceObject = CreateObject(g_RotatorProgID)
139+
l_IRotator = CType(l_DeviceObject, ASCOM.DeviceInterface.IRotatorV3)
140+
LogMsg("AccessChecks", MessageLevel.msgDebug, "Successfully created driver with interface IRotatorV3")
141+
Try
142+
LogCallToDriver("AccessChecks", "About to set Connected property")
143+
l_IRotator.Connected = True
144+
LogMsg("AccessChecks", MessageLevel.msgInfo, "Driver exposes interface IRotatorV3")
145+
LogCallToDriver("AccessChecks", "About to set Connected property")
146+
l_IRotator.Connected = False
147+
Catch ex As Exception
148+
LogMsg("AccessChecks", MessageLevel.msgInfo, "Driver does not expose interface IRotatorV3")
149+
End Try
150+
Catch ex As Exception
151+
LogMsg("AccessChecks", MessageLevel.msgInfo, "Driver does not expose interface IRotatorV3")
152+
Finally
153+
'Clean up
154+
Try : Marshal.ReleaseComObject(l_IRotator) : Catch : End Try
155+
Try : Marshal.ReleaseComObject(l_DeviceObject) : Catch : End Try
156+
l_DeviceObject = Nothing
157+
l_IRotator = Nothing
158+
GC.Collect()
159+
End Try
160+
137161
'Try client access toolkit
138162
l_DriverAccessRotator = Nothing
139163
Try

Conform/Devices/SwitchTester.vb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1066,7 +1066,7 @@
10661066
Case SwitchMethod.MinSwitchValue
10671067
DoubleValue = m_Switch.MinSwitchValue(LOW_TEST_VALUE)
10681068
Case SwitchMethod.SetSwitch
1069-
m_Switch.SetSwitchValue(LOW_TEST_VALUE, False)
1069+
m_Switch.SetSwitch(LOW_TEST_VALUE, False)
10701070
Case SwitchMethod.SetSwitchName
10711071
' Ignoring this because it is an optional parameter
10721072
Case SwitchMethod.SetSwitchValue

0 commit comments

Comments
 (0)