Add Linting Infrastructure and CI/CD Pipeline (and Prettier reformatting)#16
Merged
Conversation
Add Husky for precommit hooks Add Prettier with .prettierrrc config Add Solhint for Solidity linting with relaxed rules for now Update Node.js to 22.12.0 in Dockerfile Add detailed documentation (CI_CD.md) and modify existing ones to reflect the changes (BUILD.md , README.md) Integrate eslint-config-prettier to prevent rule conflicts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the linting infrastructure and CI/CD pipeline requirements, addressing issues #10 and #7
1. Linting Infrastructure
.prettierrcconfiguration fileeslint-config-prettierto prevent ESLint/Prettier rule conflicts.solhint.jsonconfiguration. NOTE: Solhint uses relaxed rules currently, as the contracts require major reformatting to align with default configuration.2. CI/CD Pipeline
lint -> test -> buildwith contract deployment step to followci.ymlfor the flownpm run build) to verify build succeeds3. Documentation
CI_CD.mdwith pipeline documentation and troubleshooting, and also future workBUILD.mdwith Development Workflow section explaining pre-commit hooksREADME.mdwith rootnpm installstep for Husky setup4. Commit Structure