Do not merge yet : feat(component-header-footer): add isUnbranded and unbrandedLogo props for unbranded (KE) sites - #1762
Open
juanmitriatti wants to merge 1 commit into
Open
Do not merge yet : feat(component-header-footer): add isUnbranded and unbrandedLogo props for unbranded (KE) sites#1762juanmitriatti wants to merge 1 commit into
juanmitriatti wants to merge 1 commit into
Conversation
…s for unbranded (KE) sites When isUnbranded is true, the ASU logo is replaced by unbrandedLogo (src, alt, brandLink), the universal navbar keeps only the skip-nav and report-accessibility links (focus-revealed via the standard skip-link pattern), and Sign In/Out, ASU Home, My ASU, Colleges and Schools and the ASU search input are not rendered. navTree, CTA buttons, title and parentOrg behave exactly as today. Requested by Webspark for the Unbranded (KE) profile work (WS2-2964, WS2-3128). UDS-2248
juanmitriatti
changed the title
Collaborator
|
Storybook deployed at https://unity-uds-staging.s3.us-west-2.amazonaws.com/pr-1762/index.html |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds two new optional props to the Global Header (
component-header-footer), requested by Webspark for the Unbranded (KE) profile work (WS2-2964, WS2-3128). Jira: UDS-2248.isUnbranded(bool, defaultfalse)unbrandedLogo(object:src,alt,brandLink)When
isUnbrandedis true:unbrandedLogo, mirroring howpartnerLogois injected forisPartner.:focus-within, standard skip-link pattern).Rationale: the universal nav links were hardcoded inside the React bundle with no prop to suppress them, so unbranded rendering was impossible without this change.
Changes
ASUHeader: newisUnbranded/unbrandedLogoprops, wired through the app context, PropTypes, JSDoc typedefs andtypes/main.d.ts.Logo: rendersunbrandedLogo(src/alt/brandLink) instead of the ASU logo when unbranded.UniversalNavbar: filters the nav links down to the two accessibility links, dropsLoginandSearch, and adds auds-hdr-universal-nav-unbrandedclass whose CSS visually hides the bar (still keyboard-reachable) except under:focus-within.HeaderMain: the mobile-menu search input is also suppressed when unbranded.UnbrandedStorybook story, updateddocs/README.props.md.Testing
header.test.js(logo replacement, link reduction, sign-in/search suppression, focus-reveal class, nav/title regression). Full package suite: 51/51 passing, including the Playwright dataLayer tests.yarn testat the repo root shows a pre-existing, unrelated failure in@asu/app-webdir-ui(MessageChannel is not definedjsdom environment issue); this PR touches no files in that package.