fix: Prevent caching client from caching errors

Author: caleb-leinz

src/api.rs

@@ -1515,7 +1515,7 @@ pub trait Api: Send + Sync {
     }
 }
 
-fn error_on_non_success(status: &StatusCode, body: &[u8]) -> Result<(), Error> {
+pub(crate) fn error_on_non_success(status: &StatusCode, body: &[u8]) -> Result<(), Error> {
     if !status.is_success() {
         return Err(Error::ResponseStatus {
             status: *status,

src/caching_client.rs

@@ -8,7 +8,7 @@ use url::Url;
 
 use crate::{
     Client,
-    api::{Api, Container, Value},
+    api::{Api, Container, Value, error_on_non_success},
     error::Error,
 };
 
@@ -72,6 +72,8 @@ impl Api for CachingClient {
         let fut = async move {
             let (body, status) = client.get(url_clone).await?;
 
+            error_on_non_success(&status, &body)?;
+
             Ok::<_, Error>((body, status))
         };