Show warning when extension install is disabled#17443
Open
Functionhx wants to merge 1 commit into
Open
Conversation
… is restricted When the WebUI is non-local and --enable-insecure-extension-access is not used, extension installation is disabled. Previously users would only see an assertion error after clicking Install. Now: - A warning banner is shown at the top of the Available tab listing - The Install buttons are grayed out (disabled) - The Install from URL tab also shows a warning and disables its button The banner tells users to start the WebUI with --enable-insecure-extension-access to enable extension installation. Closes AUTOMATIC1111#16871 Test Plan: - Launch with --listen and without --enable-insecure-extension-access: Verify warning banner appears on Available tab and Install buttons are disabled - Launch with --enable-insecure-extension-access: Verify no warning appears and Install buttons work normally - Launch locally without --listen: Verify no warning appears and Install buttons work normally Signed-off-by: Yuchen Fan <functionhx@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #16871.
Added warning banner and disabled Install buttons in the Available extensions tab and Install from URL tab when --enable-insecure-extension-access is not set.
Screenshots/videos:
N/A — no visual changes
Checklist: