Skip to content

Eclipse Access#1011

Merged
Mark2000 merged 3 commits into
developfrom
feature/eclipse-access
Jun 9, 2025
Merged

Eclipse Access#1011
Mark2000 merged 3 commits into
developfrom
feature/eclipse-access

Conversation

@Mark2000

@Mark2000 Mark2000 commented Jun 6, 2025

Copy link
Copy Markdown
Contributor

Description

Added support for further illumination constraints in spacecraftLocation

Verification

Existing tests pass.

Documentation

Updated docs.

Future work

Add glare computation.

@Mark2000
Mark2000 requested a review from a team as a code owner June 6, 2025 21:33
@Mark2000

Mark2000 commented Jun 6, 2025

Copy link
Copy Markdown
Contributor Author

TODO: wait for #1007 to be merged before review

Base automatically changed from feature/illumination_constraints to develop June 6, 2025 22:34
@Mark2000
Mark2000 force-pushed the feature/eclipse-access branch from 3344e05 to 0027bae Compare June 6, 2025 22:36
schaubh
schaubh requested changes Jun 7, 2025
View reviewed changes

@schaubh schaubh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Windows build failed? Not sure why. Thanks for taking a look.

Comment thread src/architecture/msgPayloadDefC/AccessMsgPayload.h
Comment thread src/simulation/environment/spacecraftLocation/spacecraftLocation.cpp
Comment thread docs/source/Support/bskReleaseNotes.rst
@Mark2000
Mark2000 force-pushed the feature/eclipse-access branch from 0027bae to 5f45c25 Compare June 9, 2025 16:10
@Mark2000
Mark2000 force-pushed the feature/eclipse-access branch from 5f45c25 to 09b47c2 Compare June 9, 2025 16:12
@Mark2000

Mark2000 commented Jun 9, 2025

Copy link
Copy Markdown
Contributor Author

Yeah, windows build was failing multiple times for no reason. Let's see if it'll pass this time.

@juan-g-bonilla

juan-g-bonilla commented Jun 9, 2025

Copy link
Copy Markdown
Contributor

Yeah, windows build was failing multiple times for no reason. Let's see if it'll pass this time.

poor Windows always getting blamed

@Mark2000

Mark2000 commented Jun 9, 2025

Copy link
Copy Markdown
Contributor Author

Windows should be blamed for not understanding and instead of &&

@Mark2000
Mark2000 force-pushed the feature/eclipse-access branch from 09b47c2 to c07722c Compare June 9, 2025 18:08
@juan-g-bonilla

juan-g-bonilla commented Jun 9, 2025

Copy link
Copy Markdown
Contributor

Windows should be blamed for not understanding and instead of &&

this is not Python have some respect and use proper short-circuit logical operators.

@Mark2000

Mark2000 commented Jun 9, 2025

Copy link
Copy Markdown
Contributor Author

BRB going to find and replace the alternative operator table throughout the whole repo: https://cppreference.com/w/cpp/language/operator_alternative.html

@Mark2000

Mark2000 commented Jun 9, 2025

Copy link
Copy Markdown
Contributor Author

@schaubh should be good for a final review

@Mark2000
Mark2000 merged commit 7eb0cd3 into develop Jun 9, 2025
21 of 22 checks passed
@Mark2000
Mark2000 deleted the feature/eclipse-access branch June 9, 2025 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@schaubh schaubh schaubh approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Mark2000 @juan-g-bonilla @schaubh