New spacecraft charging dynamics module (integration method)#1365
Conversation
leahkiner
force-pushed
the
feature/1359-sc-charging-dynamics-module
branch
from
52b6400 to
e507e24
Compare
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 76ccdd98d8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
leahkiner
force-pushed
the
feature/1359-sc-charging-dynamics-module
branch
2 times, most recently
from
07756ec to
c942c27
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cba844afb5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 42a12e9b51
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@schaubh This branch is ready for your review. |
|
Just pushed some early review comments. Will do a more detailed review later. |
leahkiner
force-pushed
the
feature/1359-sc-charging-dynamics-module
branch
5 times, most recently
from
e566150 to
ddaa70b
Compare
schaubh
force-pushed
the
feature/1359-sc-charging-dynamics-module
branch
from
8ef5485 to
b237acc
Compare
schaubh
left a comment
schaubh
left a comment
There was a problem hiding this comment.
Nice work. Just some small items to wrap up. I pushed some suggested fixes to your branch with the [squash] label.
…ojectedArea module
Add a module-local CMake dependency on dynamicsLib so the spacecraftChargingDynamics SWIG target resolves DynamicObject, DynParamManager, and RK4 integrator symbols on Windows.
leahkiner
force-pushed
the
feature/1359-sc-charging-dynamics-module
branch
from
513b1cf to
8024208
Compare
2 participants
Description
The
spacecraftChargingDynamicsclass is derived from the the parent classDynamicObject. The module integrates the electric potential of two spacecraft (a servicer and a target) in a plasma environment using a first order ordinary differential equation for each spacecraft. The charging model includes plasma electron current, plasma ion current, photoelectric current, and an optional electron beam current.Verification
The test verifies that the spacecraft charging dynamics module correctly computes the different types of currents
impacting both a target and servicer spacecraft. Specifically, this test checks that the module
correctly computes the photoelectric current, electron beam current, plasma electron current, and plasma ion
current acting on both spacecraft. While the module defaults many required variables, the user has the ability
to configure all information describing the electrons, ions, and photons using setter methods.
The test varies the servicer and target size, the electron beam parameters, and the bulk plasma ion velocity. The test
checks that the module correctly computes the photoelectric current, electron beam current, plasma electron current,
and plasma ion current acting on both spacecraft.
Documentation
RST documentation is added for the new module.
Future work
N/A