Fix vizInterface regression communicating in opNav mode with Vizard#1372
Merged
Conversation
Remove the stale pre-request receive in vizInterface image handling. The ZMQ_REQ socket must send REQUEST_IMAGE before receiving the image response frames; checking the old receive made OpNav noDisplay scenarios fail with a Vizard image request acknowledgement error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a Vizard
noDisplayOpNav regression introduced while hardening image-buffer handling. The image request path was checking a stale pre-requestzmq_recv()on aZMQ_REQsocket before sendingREQUEST_IMAGE_<cameraID>, which caused OpNav scenarios to stop withVizard image request acknowledgement was not received.This PR removes that invalid pre-request receive while keeping validation on the actual image length and image payload response frames.
Commits are organized by dependency updates and the Vizard image-request regression fix.
Verification
vizInterfacetarget successfully:git diff --check.No automated test was added because this path depends on live two-way communication with the external Vizard application.
Documentation
Added a release-note snippet and updated known issues to document the Vizard
noDisplayimage request regression fix.Reviewers should check:
src/simulation/vizard/vizInterface/vizInterface.cppdocs/source/Support/bskKnownIssues.rstdocs/source/Support/bskReleaseNotesSnippets/vizInterface-image-request.rstFuture work
A follow-up could add an integration-style test or socket-level harness for the Vizard request/response protocol so future ZMQ sequencing regressions are caught without launching the full Vizard application.