Skip to content

Camera module handling of filename variable#1375

Merged
schaubh merged 1 commit into
AVSLab:developfrom
carlo98:feature/camera_filename_processing
Apr 29, 2026
Merged

Camera module handling of filename variable#1375
schaubh merged 1 commit into
AVSLab:developfrom
carlo98:feature/camera_filename_processing

Conversation

@carlo98
Copy link
Copy Markdown
Contributor

@carlo98 carlo98 commented Apr 28, 2026

Description

Fixed camera module inconsistency with its documentation where images loaded via filename parameter were processed through filters but never published to imageOutMsg. Refactored camera.cpp to ensure filename-loaded images follow the same processing and publishing pipeline as images from imageInMsg.

Verification

  • Added new unit test test_no_image_zero_msg() in test_camera.py to verify zeroed-out output message when no image source is provided.
  • Existing camera tests continue to validate the complete pipeline.

Documentation

  • Added release note snippet.
  • Updated docs/source/Support/bskKnownIssues.rst to document the fix.

Future work

Would be nice to have a module that loads images from a directory without having to manually change the filename variable.

@carlo98 carlo98 force-pushed the feature/camera_filename_processing branch from edad8a4 to 874bbe0 Compare April 28, 2026 21:16
@carlo98 carlo98 marked this pull request as ready for review April 28, 2026 22:00
@carlo98 carlo98 requested a review from a team as a code owner April 28, 2026 22:00
@chatgpt-codex-connector
Copy link
Copy Markdown

chatgpt-codex-connector Bot commented Apr 28, 2026

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

schaubh
schaubh requested changes Apr 29, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@schaubh schaubh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor thing to look at.

Comment thread src/simulation/sensors/camera/camera.cpp
juan-g-bonilla added a commit that referenced this pull request Apr 29, 2026
@juan-g-bonilla
[#1375] Move MeanRevertingNoise base class to _GeneralModuleFiles
efbf4ae 
Moves meanRevertingNoise.h/.cpp to _GeneralModuleFiles where abstract
base classes belong. Creates a dedicated MJMeanRevertingNoise SWIG module
there so Python subclassing of the base class continues to work.
juan-g-bonilla added a commit that referenced this pull request Apr 29, 2026
@juan-g-bonilla
[#1375] Add stochasticAtmDensity as a standalone BSK module
c274740 
Moves StochasticAtmDensity out of meanRevertingNoise/ into its own
folder with a dedicated MJStochasticAtmDensity SWIG module and .rst.
Updates the unit test and scenarioStochasticDrag to import from the
new module name.
juan-g-bonilla added a commit that referenced this pull request Apr 29, 2026
@juan-g-bonilla
[#1375] Add stochasticDragCoeff as a standalone BSK module
5b94144 
Moves StochasticDragCoeff out of meanRevertingNoise/ into its own
folder with a dedicated MJStochasticDragCoeff SWIG module, .rst,
and a new unit test that validates OU statistics on drag coefficient.
juan-g-bonilla added a commit that referenced this pull request Apr 29, 2026
@juan-g-bonilla
[#1375] Rename PIDControllers folder to JointPIDController
9c9f60a 
Renames the folder, SWIG module (MJPIDControllers -> MJJointPIDController),
and test file to match the single concrete class it contains. Adds
JointPIDController.rst and updates scenarioBranchingPanels to import
from the new module name.
juan-g-bonilla added a commit that referenced this pull request Apr 29, 2026
@juan-g-bonilla
[#1375] Add NBodyGravity.rst
5119889
juan-g-bonilla added a commit that referenced this pull request Apr 29, 2026
@juan-g-bonilla
[#1375] Add release note snippet
4f346d0
juan-g-bonilla added a commit that referenced this pull request Apr 29, 2026
@juan-g-bonilla
[#1375] Add stochasticAtmDensity as a standalone BSK module
f967581 
Moves StochasticAtmDensity out of meanRevertingNoise/ into its own
folder with a dedicated MJStochasticAtmDensity SWIG module and .rst.
Updates the unit test and scenarioStochasticDrag to import from the
new module name.
juan-g-bonilla added a commit that referenced this pull request Apr 29, 2026
@juan-g-bonilla
[#1375] Add stochasticDragCoeff as a standalone BSK module
0bac2ab 
Moves StochasticDragCoeff out of meanRevertingNoise/ into its own
folder with a dedicated MJStochasticDragCoeff SWIG module, .rst,
and a new unit test that validates OU statistics on drag coefficient.
juan-g-bonilla added a commit that referenced this pull request Apr 29, 2026
@juan-g-bonilla
[#1375] Rename PIDControllers folder to JointPIDController
1d9f415 
Renames the folder, SWIG module (MJPIDControllers -> MJJointPIDController),
and test file to match the single concrete class it contains. Adds
JointPIDController.rst and updates scenarioBranchingPanels to import
from the new module name.
juan-g-bonilla added a commit that referenced this pull request Apr 29, 2026
@juan-g-bonilla
[#1375] Add NBodyGravity.rst
83f55f2
juan-g-bonilla added a commit that referenced this pull request Apr 29, 2026
@juan-g-bonilla
[#1375] Add release note snippet
4fdbe23
juan-g-bonilla added a commit that referenced this pull request Apr 29, 2026
@juan-g-bonilla
[#1375] Move MeanRevertingNoise base class to _GeneralModuleFiles
099ea4f 
Moves meanRevertingNoise.h/.cpp to _GeneralModuleFiles where abstract
base classes belong. Creates a dedicated MJMeanRevertingNoise SWIG module
there so Python subclassing of the base class continues to work.
juan-g-bonilla added a commit that referenced this pull request Apr 29, 2026
@juan-g-bonilla
[#1375] Add stochasticAtmDensity as a standalone BSK module
5ded49a 
Moves StochasticAtmDensity out of meanRevertingNoise/ into its own
folder with a dedicated MJStochasticAtmDensity SWIG module and .rst.
Updates the unit test and scenarioStochasticDrag to import from the
new module name.
juan-g-bonilla added a commit that referenced this pull request Apr 29, 2026
@juan-g-bonilla
[#1375] Add stochasticDragCoeff as a standalone BSK module
1cf72e1 
Moves StochasticDragCoeff out of meanRevertingNoise/ into its own
folder with a dedicated MJStochasticDragCoeff SWIG module, .rst,
and a new unit test that validates OU statistics on drag coefficient.
juan-g-bonilla added a commit that referenced this pull request Apr 29, 2026
@juan-g-bonilla
[#1375] Rename PIDControllers folder to JointPIDController
354eb1c 
Renames the folder, SWIG module (MJPIDControllers -> MJJointPIDController),
and test file to match the single concrete class it contains. Adds
JointPIDController.rst and updates scenarioBranchingPanels to import
from the new module name.
juan-g-bonilla added a commit that referenced this pull request Apr 29, 2026
@juan-g-bonilla
[#1375] Add NBodyGravity.rst
743534b
juan-g-bonilla added a commit that referenced this pull request Apr 29, 2026
@juan-g-bonilla
[#1375] Add release note snippet
02d5eff
carlo98 added a commit to carlo98/basilisk that referenced this pull request Apr 29, 2026
@carlo98
[AVSLab#1375] Writing output img when using filename
a722fa0
@carlo98 carlo98 force-pushed the feature/camera_filename_processing branch from 874bbe0 to a722fa0 Compare April 29, 2026 14:45
@carlo98 carlo98 force-pushed the feature/camera_filename_processing branch from a722fa0 to dd74669 Compare April 29, 2026 14:46
@carlo98
Copy link
Copy Markdown
Contributor Author

carlo98 commented Apr 29, 2026

I commited a version with two BSK_ERROR, but I was thinking that a nice idea could be do emit a BSK_ERROR if loading from the filesystem fails and a BSK_WARNING+zero output msg if the failures comes from the input msg. What do you think @schaubh ?

@juan-g-bonilla juan-g-bonilla mentioned this pull request Apr 29, 2026
Merged
@schaubh
Copy link
Copy Markdown
Contributor

schaubh commented Apr 29, 2026

If loading fails I would rather have a BSK_ERROR.

@schaubh schaubh merged commit 50acbbf into AVSLab:develop Apr 29, 2026
7 checks passed
@schaubh schaubh self-assigned this Apr 29, 2026
@schaubh schaubh added this to Basilisk Apr 29, 2026
@github-project-automation github-project-automation Bot moved this to ✅ Done in Basilisk Apr 29, 2026
@schaubh schaubh added the enhancement New feature or request label Apr 29, 2026
@carlo98 carlo98 deleted the feature/camera_filename_processing branch April 29, 2026 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@schaubh schaubh schaubh approved these changes

Assignees

@schaubh schaubh

Labels

enhancement New feature or request

Projects

Basilisk
Status: ✅ Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@carlo98 @schaubh