[#632] Fix SWIG re-registration bug in dataFileToViz#1380
Closed
sassy-asjp wants to merge 1 commit into
Closed
Conversation
dataFileToViz SWIG file unintentionally caused SWIG type wrappers incompatible to the vizInterface ones to be generated. Some combinations of dataFileToViz and vizInterface imports will thus cause usage of one to fail due to generic SwigPyObjects getting emitted instead of the proper Python wrappers.
sassy-asjp
force-pushed
the
fix/bsk-632-dataFileToViz-reregister-fix
branch
from
29c6468 to
d74a7bf
Compare
Contributor
Author
|
Ah, actually this fix doesn't actually work for everything. At least I think the root cause is clear. I'll think a bit more about the correct fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
dataFileToVizSWIG file unintentionally caused SWIG type wrappers incompatible to thevizInterfaceones to be generated. Some combinations of dataFileToViz and vizInterface imports will thus cause usage of one to fail due to generic SwigPyObjects getting emitted instead of the proper Python wrappers.Instead of just including the
vizStructures.hinsidedataFileToViz.i, I included declared just what was needed for the SWIG build.Verification
Failing combinations of tests now pass, for example
pytest -vv tests/test_scenarioAttLocPoint.py tests/test_scenarioDataToViz.py tests/test_scenarioAttitudeConstrainedManeuver.pynow passes.Documentation
None
Future work
None