Skip to content

update minimum swig to 4.4.1#1383

Merged
schaubh merged 4 commits into
developfrom
feature/update_swig
May 3, 2026
Merged

update minimum swig to 4.4.1#1383
schaubh merged 4 commits into
developfrom
feature/update_swig

Conversation

@schaubh
Copy link
Copy Markdown
Contributor

@schaubh schaubh commented May 3, 2026

  • Review: By commit
  • Merge strategy: Merge (no squash)

Description

This PR raises the supported SWIG 4.x build requirement to SWIG 4.4.1 for Basilisk source builds and Python build requirements. The CMake SWIG detection was simplified to a single versioned find_package(SWIG 4.4.1...<5 REQUIRED COMPONENTS python) check now that the minimum SWIG version is unconditional.

This update provides SWIG ABI 5 support between BSK and BSK plugins.

Verification

Validated locally using the repo .venv environment:

  • .venv/bin/swig -version reports SWIG 4.4.1.
  • .venv/bin/python successfully parses pyproject.toml.
  • .venv/bin/python -m py_compile setup.py passes.
  • The release-note snippet validates with rst2pseudoxml.
  • git diff --check passes.
  • A CMake configure smoke check confirms .venv/bin/swig satisfies the new 4.4.1...<5 requirement.

No runtime tests were added because this is a build dependency/configuration update.

Documentation

Added a release-note snippet describing SWIG ABI 5 support between BSK and BSK plugins. Updated the known-issues SWIG 4.4.0 guidance. Removed the stale MuJoCo-specific SWIG dependency note so SWIG requirements remain centralized in the build configuration.

Future work

None.

@schaubh schaubh self-assigned this May 3, 2026
@schaubh schaubh added the build Build system or compilation enhancement label May 3, 2026
@schaubh schaubh requested a review from a team as a code owner May 3, 2026 13:53
@schaubh schaubh added this to Basilisk May 3, 2026
@schaubh schaubh force-pushed the feature/update_swig branch from a70e547 to 230380a Compare May 3, 2026 13:54
@schaubh schaubh moved this to 👀 In review in Basilisk May 3, 2026
@schaubh schaubh merged commit e9317ce into develop May 3, 2026
7 checks passed
schaubh added a commit that referenced this pull request May 3, 2026
This provides consistent ABI 5 support across BSK and BSK-SDK plugin builds
schaubh added a commit that referenced this pull request May 3, 2026
@schaubh schaubh deleted the feature/update_swig branch May 3, 2026 16:04
@github-project-automation github-project-automation Bot moved this from 👀 In review to ✅ Done in Basilisk May 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Build system or compilation enhancement

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

1 participant