Edit pull-request.yml to run mujoco tests in some jobs#936
Merged
Conversation
juan-g-bonilla
requested review from
schaubh
and removed request for
schaubh
juan-g-bonilla
force-pushed
the
feature/run-mujoco-pr-action
branch
2 times, most recently
from
20e38bd to
9fac9c4
Compare
juan-g-bonilla
commented
Feb 21, 2025
juan-g-bonilla
force-pushed
the
feature/run-mujoco-pr-action
branch
from
9fac9c4 to
0379710
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The updated workflow file calls
conanfile.pywith--mujoco True and --mujocoReplay Truefor a Linux, Windows, and Macos job, which are intended to test mujoco in for PR #908 . Both the Windows and Linux jobs were modified to use SWIG 4.2.1, which is required for running mujoco. The modified jobs have been renamed, so github must be configured for the new names.Future work
Transition ubuntu20 jobs to Ubuntu24 (the 20 image is deprecated already), which comes with swig >=v4.2.1 built in. For Windows, look out for chocolatey supporting 4.2.1, then use choco instead of the current manual installation.