Build fails with cmake 4.x#966
Merged
Merged
Conversation
schaubh
added
bug
juan-g-bonilla
approved these changes
Mar 30, 2025
The zeromq dependency is installed if cppzmq is required. The encryption setting only needs to be set if we build with vizInterface or opNav. Before the setting was always set. In fact, it was being set twice?
We now need cmake<4.0. This is easily controlled if we let pip install cmake into our python virtual environment. This also allows the user to use other versions of cmake for other projects if needed.
The RST documentation setups a virtual environment in .venv. But, in places the RST documentation uses (venv) instead of (.venv). This is now corrected.
Rather, now cmake is installed via pip into the local virtual environment.
schaubh
force-pushed
the
feature/cmake_4_0_issue
branch
from
76d9480 to
53856d6
Compare
This allows pip wheels to be built again.
schaubh
force-pushed
the
feature/cmake_4_0_issue
branch
from
5d1f880 to
b5428e2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A clean build fails building in the
conandependency install process forzeromq/4.3.5. We need to usecmake<4.0for now.The install process is changed to install
cmake<4.0with the pip command by adding this requirement torequirements_dev.txt. The CI build verification scripts are changed to not explicitly installcmakeanymore. Build instructions are updated to remove the step to manually install cmake.Verification
All CI build scripts pass again across all platforms.
Documentation
Updated release notes, as well as the platform instructions. RST documentation was updated to support adding a button to copy the code blocks in HTML documentation.
Future work
When
zeromqis compatible withcmake>3.xthe requirement can be updated again to allow newer versions ofcmake.