Skip to content

Bug/187 srp parse and load xml#970

Merged
Natsoulas merged 2 commits into
developfrom
bug/187-srp-parse-and-load-xml
Apr 2, 2025
Merged

Bug/187 srp parse and load xml#970
Natsoulas merged 2 commits into
developfrom
bug/187-srp-parse-and-load-xml

Conversation

@Natsoulas
Copy link
Copy Markdown
Contributor

Description

Fixed a ValueError that occurred when using VS Code's Python debugger with the radiation pressure module. The issue was caused by numpy arrays that reference other arrays not being able to be resized without setting refcheck=False. The fix adds this parameter to the resize calls in parseSRPLookup.py.

The commits are organized as:

  1. Fix the resize calls in parseSRPLookup.py
  2. Update release notes to document the change

Verification

The changes were validated by:

  1. Running the existing test_radiationPressure.py unit tests to ensure the core functionality wasn't affected
  2. Manually verifying that the VS Code debugger now works with scenarios using the radiation pressure module in python 3.10.12

Documentation

  • Updated the release notes to document this bug fix
  • No other documentation changes were needed as this was a debugging-specific fix that doesn't affect the module's usage or interface

Future work

No future work anticipated.

@Natsoulas Natsoulas requested a review from a team as a code owner April 2, 2025 00:07
@Natsoulas Natsoulas requested a review from schaubh April 2, 2025 00:07
@Natsoulas Natsoulas self-assigned this Apr 2, 2025
@Natsoulas Natsoulas added the bug Something isn't working label Apr 2, 2025
@Natsoulas Natsoulas moved this to 👀 In review in Basilisk Apr 2, 2025
Copy link
Copy Markdown
Contributor

@schaubh schaubh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the quick fix.

@Natsoulas Natsoulas force-pushed the bug/187-srp-parse-and-load-xml branch from cce3242 to 42bd638 Compare April 2, 2025 16:29
@Natsoulas Natsoulas merged commit ce2572c into develop Apr 2, 2025
11 checks passed
@Natsoulas Natsoulas deleted the bug/187-srp-parse-and-load-xml branch April 2, 2025 17:39
@github-project-automation github-project-automation Bot moved this from 👀 In review to ✅ Done in Basilisk Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

Unable to use debugger on scenario which calls parseAndLoadXML() from radiationPressure.py

2 participants