Skip to content

Pin python dependencies#984

Merged
Natsoulas merged 4 commits into
developfrom
enhancement/214-pin-all-python-dependency-versions-ids
Apr 24, 2025
Merged

Pin python dependencies#984
Natsoulas merged 4 commits into
developfrom
enhancement/214-pin-all-python-dependency-versions-ids

Conversation

@Natsoulas
Copy link
Copy Markdown
Contributor

@Natsoulas Natsoulas commented Apr 19, 2025

Description

This PR pins all python dependencies to their latest versions as of the date of this PR (4/18/2025). The packages shared between the pyproject.toml file and requirements_dev.txt are updated to match within the .txt file.

The only new feature introduced in this PR is a weekly github workflow job that tests the latest versions of BSK's python dependencies on the latest python version on the latest macOS. This is to assist maintainers in updating dependency pinnings and refactoring code where needed.

Verification

Local building and unit testing as well as pull request CI tests. This is not a terribly invasive PR.

Documentation

N/A, release notes updated

Future work

Update pinnings where appropriate. Consolidate dependencies by moving all to pyproject.toml and deleting .txt files. Also, update lower bound of all pinnings once python 3.8 is depreciated as it is the primary cause of the lower bounds existence.

@Natsoulas Natsoulas added the enhancement New feature or request label Apr 19, 2025
@Natsoulas Natsoulas self-assigned this Apr 19, 2025
@Natsoulas Natsoulas requested a review from a team as a code owner April 19, 2025 02:10
@Natsoulas Natsoulas force-pushed the enhancement/214-pin-all-python-dependency-versions-ids branch from 1c21dfa to 961c481 Compare April 19, 2025 02:30
@Natsoulas Natsoulas changed the title pin python dependencies in txt files pin python dependencies Apr 19, 2025
@Natsoulas Natsoulas changed the title pin python dependencies Pin python dependencies in .txt files Apr 19, 2025
@Natsoulas Natsoulas changed the title Pin python dependencies in .txt files Pin python dependencies Apr 19, 2025
@Natsoulas Natsoulas force-pushed the enhancement/214-pin-all-python-dependency-versions-ids branch 2 times, most recently from 4c46723 to 978aa82 Compare April 19, 2025 02:46
@Natsoulas Natsoulas requested a review from schaubh April 19, 2025 19:02
@Natsoulas Natsoulas moved this to 👀 In review in Basilisk Apr 19, 2025
Comment thread conanfile.py Outdated
Comment thread .github/workflows/requirements_dev_canary.txt Outdated
@schaubh schaubh force-pushed the enhancement/214-pin-all-python-dependency-versions-ids branch from c46a6be to d4681f4 Compare April 21, 2025 14:57
@Natsoulas Natsoulas force-pushed the enhancement/214-pin-all-python-dependency-versions-ids branch 2 times, most recently from fc44001 to a079886 Compare April 24, 2025 03:01
@Natsoulas Natsoulas requested a review from schaubh April 24, 2025 03:30
@schaubh schaubh force-pushed the enhancement/214-pin-all-python-dependency-versions-ids branch from a079886 to 5f88269 Compare April 24, 2025 13:57
Copy link
Copy Markdown
Contributor

@schaubh schaubh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, I like the new canary CI test build solution. Thanks for the support. Did a rebase. I'm approving so you can close after the CI tests pass.

@Natsoulas Natsoulas merged commit 620bf83 into develop Apr 24, 2025
30 of 34 checks passed
@Natsoulas Natsoulas deleted the enhancement/214-pin-all-python-dependency-versions-ids branch April 24, 2025 17:01
@github-project-automation github-project-automation Bot moved this from 👀 In review to ✅ Done in Basilisk Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants