Hotfix/Compiler Warnings MuJocO

[juan-g-bonilla]

• Tickets addressed: Hotfix
• Review: By commit
• Merge strategy: Merge (no squash)

Description

Some mujocoDynamics code was raising compiler warnings. These commits address these.

One of the warnings was due to a missing override keyword.

The other warning was raised because some functions were reaching the control flow end without returning the expected value. However, this is because a logAndThrow was being called, which throws an error and thus interrupts normal control flow. By letting the compiler know that this function is [[noreturn]], it no longer cares about the return on that path of the control flow.

Verification

I'll check the MacOS build logs for compiler warnings (I'm tagging this PR dont merge until I've done this manual check).

[schaubh]

Just tried building on macOS Terminal using cmake and I didn't see the compiler warnings I saw before.

Compiled in Xcode and I get this compiler warning:

ld: warning: ignoring duplicate libraries: '/Users/hp/Repos/basilisk/dist3/Basilisk/libArchitectureUtilities.a', '/Users/hp/Repos/basilisk/dist3/Basilisk/libcMsgCInterface.a'

and the attached warning about an implicit conversion in MJSite.cpp.

[juan-g-bonilla]

Just tried building on macOS Terminal using cmake and I didn't see the compiler warnings I saw before.

Compiled in Xcode and I get this compiler warning:

ld: warning: ignoring duplicate libraries: '/Users/hp/Repos/basilisk/dist3/Basilisk/libArchitectureUtilities.a', '/Users/hp/Repos/basilisk/dist3/Basilisk/libcMsgCInterface.a'

and the attached warning about an implicit conversion in MJSite.cpp.

Just pushed a commit for the implicit conversion warning. Not sure about the double linkage error, ill investigate further.

[juan-g-bonilla]

Just tried building on macOS Terminal using cmake and I didn't see the compiler warnings I saw before.

Compiled in Xcode and I get this compiler warning:

ld: warning: ignoring duplicate libraries: '/Users/hp/Repos/basilisk/dist3/Basilisk/libArchitectureUtilities.a', '/Users/hp/Repos/basilisk/dist3/Basilisk/libcMsgCInterface.a'

and the attached warning about an implicit conversion in MJSite.cpp.

I think I also fixed the double linkage issue. I don't see it in my terminal anymore.

[schaubh]

Cool, thanks for addressing these warnings. Yesterday I was not able to build BSK+mujoco in Xcode, after your commits earlier today it works again. This gives us a clean code base to work with 🤠

[juan-g-bonilla]

@schaubh ready for review. I don't see any compiler warnings on the Macos build.

[schaubh]

Good to go.