Skip to content

Commit 92ed906

Browse files
committed
[#289] Fix initial data bug
1 parent 7ca1166 commit 92ed906

3 files changed

Lines changed: 5 additions & 0 deletions

File tree

docs/source/release_notes.rst

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,7 @@ Development - |version|
4545
:class:`~bsk_rl.sim.dyn.RSODynModel`. An example environment setup is described in the
4646
`RSO Inspection <examples/rso_inspection.ipynb>`_ example.
4747
* Add a maximum duration option to :class:`~bsk_rl.act.Image`.
48+
* Fix a bug where a satellite's initial data was never added to the rewarder.
4849

4950

5051
Version 1.1.0

src/bsk_rl/gym.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -312,6 +312,7 @@ def reset(
312312

313313
for satellite in self.satellites:
314314
self.rewarder.create_data_store(satellite)
315+
self.rewarder.data += satellite.data_store.data
315316
satellite.reset_pre_sim_init()
316317

317318
self.simulator = Simulator(

tests/unittest/test_gym_env.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -95,9 +95,12 @@ def test_reset(self, mock_sim):
9595
)
9696
mock_sat = env.satellites[0]
9797
mock_rewarder = env.rewarder
98+
mock_rewarder.data = 0
99+
mock_sat.data_store.data = 100
98100
env.unwrapped.world_args_generator = {"utc_init": "a long time ago"}
99101
env.communicator = MagicMock(last_communication_time=0.0)
100102
env.reset()
103+
assert mock_rewarder.data == 100
101104
mock_sat.generate_sat_args.assert_called_with(utc_init="a long time ago")
102105
mock_sim.assert_called_once()
103106
mock_sat.reset_pre_sim_init.assert_called_once()

0 commit comments

Comments
 (0)