[#265] Maximum range checking model#267
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR implements a maximum range checking feature between satellites with an accompanying integration test and updates to satellite command generation. Key changes include:
- Adding the MaxRangeDynModel in the dynamics module to report range violations.
- Refactoring the _satellite_command in the Satellite class to use Simulator.get_satellite for cleaner string evaluation.
- Introducing integration tests for the max range checking logic.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/unittest/sats/test_satellite.py | Updated tests to bind get_satellite using partial for eval calls. |
| tests/integration/sim/test_int_dynamics.py | Added integration tests for the maximum range dynamics model. |
| src/bsk_rl/sim/simulator.py | Added a get_satellite method to look up satellites by name. |
| src/bsk_rl/sim/dyn.py | Added MaxRangeDynModel with event-based range checking. |
| src/bsk_rl/sats/satellite.py | Modified _satellite_command to simplify command generation. |
| docs/source/release_notes.rst | Updated release notes to document the new feature. |
Mark2000
force-pushed
the
feature/265-range-checking
branch
2 times, most recently
from
May 28, 2025 00:12
f426897 to
388934b
Compare
Yume27
self-requested a review
May 30, 2025 21:59
Yume27
reviewed
May 30, 2025
Yume27
approved these changes
Jun 2, 2025
Yume27
left a comment
Contributor
There was a problem hiding this comment.
Like the get_satellite function, and passed all pytest locally.
Mark2000
force-pushed
the
feature/265-range-checking
branch
from
June 5, 2025 21:10
388934b to
e70f5cf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #265
Adds a max range checking feature to force a deputy to stay within a radius of a chief.
Also refactors indexing satellites from the simulator.
Type of change
How should this pull request be reviewed?
How Has This Been Tested?
Added integrated test.
Future Work
Potential to extend to multiple satellites, but probably not needed.
Checklist