Skip to content

[#266] Orbital element observations#272

Merged
Mark2000 merged 2 commits into
developfrom
feature/266-oe-obs
Jun 12, 2025
Merged

[#266] Orbital element observations#272
Mark2000 merged 2 commits into
developfrom
feature/266-oe-obs

Conversation

@Mark2000

@Mark2000 Mark2000 commented Jun 6, 2025

Copy link
Copy Markdown
Contributor

Description

Closes #266

Adds orbital element observations.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How should this pull request be reviewed?

  • By commit
  • All changes at once

How Has This Been Tested?

Added some tests.

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation and release notes
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

Copilot AI review requested due to automatic review settings June 6, 2025 03:13

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

@Mark2000
Mark2000 force-pushed the feature/266-oe-obs branch from 34cd3c8 to abb5988 Compare June 6, 2025 03:15
Comment thread src/bsk_rl/sim/dyn.py Outdated

@LorenzzoQM LorenzzoQM left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition! It should be good to merge after adding the unit for the inclination (to avoid any possible confusion).

@Mark2000
Mark2000 force-pushed the feature/266-oe-obs branch 3 times, most recently from 1cbca65 to e127763 Compare June 11, 2025 00:01
@Mark2000
Mark2000 force-pushed the feature/266-oe-obs branch 2 times, most recently from 053b46e to 8c3e4dc Compare June 12, 2025 00:03
@Mark2000
Mark2000 force-pushed the feature/266-oe-obs branch from 8c3e4dc to a4189a0 Compare June 12, 2025 00:05
@Mark2000
Mark2000 merged commit b52027b into develop Jun 12, 2025
9 of 10 checks passed
@Mark2000
Mark2000 deleted the feature/266-oe-obs branch June 12, 2025 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Orbital element observation(s)

3 participants