[#244] Refactor dynamics and fsw#273
Merged
Merged
Conversation
Mark2000
force-pushed
the
feature/244-separate-files
branch
2 times, most recently
from
June 6, 2025 22:39
6cd5c2b to
4407947
Compare
Mark2000
marked this pull request as ready for review
June 6, 2025 22:39
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the dynamics and flight software (FSW) modules, primarily updating module paths and reorganizing code. Key changes include:
- Updating patch decorator paths in unit and integration tests to reflect refactored module structures.
- Moving and removing legacy FSW model implementations from the base module.
- Introducing updated dynamics models with improved class hierarchies.
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/unittest/sim/test_fsw.py | Updated patch path for aliveness checkers to use the new base module reference. |
| tests/unittest/sim/test_dynamics.py | Modified patch paths for spacecraft location and storage unit to reflect refactored module structure. |
| tests/integration/sim/test_int_dynamics.py | Updated reference to FullFeaturedDynModel after refactor. |
| tests/integration/comm/test_int_communication.py | Adjusted dynamics model import and inlined FullFeaturedDynModel definition. |
| src/bsk_rl/sim/fsw/orbital.py | New FSW model for orbital maneuvers added. |
| src/bsk_rl/sim/fsw/ground_imaging.py | New FSW model for ground imaging scenarios introduced. |
| src/bsk_rl/sim/fsw/base.py | Legacy imaging FSW models removed and all updated accordingly. |
| src/bsk_rl/sim/fsw/init.py | Updated package exports to match refactored module structure. |
| src/bsk_rl/sim/dyn/relative_motion.py | New relative motion dynamics added for LOS communications. |
| src/bsk_rl/sim/dyn/init.py | Updated dynamics module with new FullFeaturedDynModel export. |
Comments suppressed due to low confidence (2)
tests/unittest/sim/test_dynamics.py:178
- The updated patch path using 'relative_motion.spacecraftLocation' should be verified against the new module layout to ensure that tests properly intercept the intended functionality.
@patch(module + "relative_motion.spacecraftLocation", MagicMock())
tests/unittest/sim/test_dynamics.py:262
- Ensure that the new patch path for 'partitionedStorageUnit' in the ground_imaging module accurately reflects the refactored file structure and is consistent with the intended functionality.
@patch(module + "ground_imaging.partitionedStorageUnit", MagicMock())
Mark2000
force-pushed
the
feature/244-separate-files
branch
from
June 6, 2025 22:49
4407947 to
dfa0dc8
Compare
Mark2000
force-pushed
the
feature/244-separate-files
branch
from
June 6, 2025 22:55
dfa0dc8 to
5275382
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #244
Type of change
How should this pull request be reviewed?
How Has This Been Tested?
Passes tests.
Future Work
None
Checklist