RSO inspection scenario

[Mark2000]

Description

Closes #144

Adds dynamics, fsw, scenarios, data, examples, and utilities for the RSO scenario.

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

How should this pull request be reviewed?

• By commit
• All changes at once

How Has This Been Tested?

Adding tests for components.

Future Work

None.

Checklist

• I have performed a self-review of my code
• I have commented my code in hard-to-understand areas
• I have made corresponding changes to the documentation and release notes
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works

[Copilot]

Pull Request Overview

Adds a new RSO (Resident Space Object) inspection scenario, including scenario definitions, dynamics and FSW models, data recording and reward logic, observation utilities, tests, examples, and documentation updates.

• Introduce RSOPoints and SphericalRSO scenario with Fibonacci‐sphere point generation
• Add RSODynModel, RSOInspectorDynModel, and RSOInspectorFSWModel for inspection dynamics and control
• Implement RSOInspectionData, RSOInspectionDataStore, and RSOInspectionReward with corresponding tests and integration example

Reviewed Changes

Copilot reviewed 19 out of 19 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
tests/unittest/scene/test_rso_points.py	Tests for RSOPoints reset logic and SphericalRSO point generation
tests/unittest/obs/test_relative_observations.py	Tests for new rso_imaged_regions observation function
tests/unittest/data/test_rso_inspection_data.py	Tests for RSOInspectionData addition, datastore, and reward logic
tests/integration/test_int_rso_env.py	Integration test for the full RSO inspection environment
src/bsk_rl/utils/orbital.py	Added random_unit_vector and fibonacci_sphere utilities
src/bsk_rl/sim/fsw/rso_inspection.py	New ContinuousImagingFSWModel subclass for RSO inspection
src/bsk_rl/sim/fsw/init.py	Export RSOInspectorFSWModel
src/bsk_rl/sim/dyn/rso_inspection.py	New RSODynModel and RSOInspectorDynModel
src/bsk_rl/sim/dyn/base.py	Fixed orbital element property names and beta_angle references
src/bsk_rl/sim/dyn/init.py	Export new RSO inspection dynamics models
src/bsk_rl/scene/rso_points.py	Scenario classes RSOPoints and SphericalRSO
src/bsk_rl/scene/init.py	Import and document new RSO scenarios
src/bsk_rl/obs/relative_observations.py	Added rso_imaged_regions utility and imports
src/bsk_rl/data/rso_inspection.py	DataStore and GlobalReward classes for RSO inspection
src/bsk_rl/data/init.py	Export RSOInspectionReward and update docs
src/bsk_rl/act/continuous_actions.py	Consolidate logging calls and fix logger usage
examples/_default.rst	Add RSO Inspection to examples TOC
docs/source/release_notes.rst	Document release notes for RSO inspection feature

Comments suppressed due to low confidence (4)

src/bsk_rl/sim/dyn/rso_inspection.py:31

• The parameter name 'range' shadows the built-in function. Consider renaming it to 'range_max' or similar for clarity.

    def add_rso_point(

tests/unittest/data/test_rso_inspection_data.py:15

• [nitpick] Using 'sum' as a parameter name shadows the built-in sum() function. Consider renaming it to 'expected'.

    "a, b, sum",

src/bsk_rl/data/rso_inspection.py:42

• Docstring says 'boolean AND' but the implementation uses logical OR to accumulate statuses. Update the doc to reflect OR logic.

    def __add__(self, other: "RSOInspectionData"):

src/bsk_rl/data/init.py:69

• [nitpick] The reST table separator line is missing leading '|' characters, which may break formatting. Ensure each table row and separator starts with '|'.

-----------------------------+-------------------------------------------------------------------------+---------------------------------------------------------------------+

[dhutererprats]

Only minor changes suggested and some comments left here and there.
In the future if we want to look at self- and inspector-to-RSO shadowing, we might want to change some of the architecture, for example pointing to a region on RSO rather than center and also changing the range requirement from being point dependent to being dependent on the instrument on the Inspector.

Great work overall!

[Mark2000]

@dhutererprats should be good for a rereview

[dhutererprats]

Looks good now!