[#144] Add Hill-frame impulsive thrust#275
Merged
Merged
Conversation
Mark2000
force-pushed
the
feature/144-hill-frame-thrust
branch
2 times, most recently
from
June 12, 2025 00:35
c805df3 to
bc1614a
Compare
Mark2000
marked this pull request as ready for review
June 12, 2025 00:35
There was a problem hiding this comment.
Pull Request Overview
Adds the ability to perform impulsive thrusts in another satellite’s Hill frame by introducing a new action, updating the action registry and docs, and providing integration tests.
- Introduce
ImpulsiveThrustHillincontinuous_actions.py - Register
ImpulsiveThrustHillinact/__init__.pyand update release notes - Add an integration test exercising Hill‐frame thrust in
test_int_actions_continuous.py
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/integration/act/test_int_actions_continuous.py | Added TestHillImpulsiveThrust to verify Hill‐frame delta-V and time drift |
| src/bsk_rl/act/continuous_actions.py | New ImpulsiveThrustHill subclass converting Hill-frame thrust to inertial |
| src/bsk_rl/act/init.py | Registered ImpulsiveThrustHill and updated import/export list |
| docs/source/release_notes.rst | Documented new ImpulsiveThrustHill feature in release notes |
Mark2000
force-pushed
the
feature/144-hill-frame-thrust
branch
from
June 12, 2025 19:35
e298b66 to
bc6242c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a Hill-frame thrust.
Type of change
How should this pull request be reviewed?
How Has This Been Tested?
Added tests
Future Work
None
Checklist