Skip to content

[#144] Add Hill-frame impulsive thrust#275

Merged
Mark2000 merged 1 commit into
developfrom
feature/144-hill-frame-thrust
Jun 12, 2025
Merged

[#144] Add Hill-frame impulsive thrust#275
Mark2000 merged 1 commit into
developfrom
feature/144-hill-frame-thrust

Conversation

@Mark2000

@Mark2000 Mark2000 commented Jun 12, 2025

Copy link
Copy Markdown
Contributor

Description

Adds a Hill-frame thrust.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How should this pull request be reviewed?

  • By commit
  • All changes at once

How Has This Been Tested?

Added tests

Future Work

None

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation and release notes
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@Mark2000
Mark2000 force-pushed the feature/144-hill-frame-thrust branch 2 times, most recently from c805df3 to bc1614a Compare June 12, 2025 00:35
@Mark2000
Mark2000 requested a review from dhutererprats June 12, 2025 00:35
@Mark2000
Mark2000 marked this pull request as ready for review June 12, 2025 00:35
Copilot AI review requested due to automatic review settings June 12, 2025 00:35

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds the ability to perform impulsive thrusts in another satellite’s Hill frame by introducing a new action, updating the action registry and docs, and providing integration tests.

  • Introduce ImpulsiveThrustHill in continuous_actions.py
  • Register ImpulsiveThrustHill in act/__init__.py and update release notes
  • Add an integration test exercising Hill‐frame thrust in test_int_actions_continuous.py

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
tests/integration/act/test_int_actions_continuous.py Added TestHillImpulsiveThrust to verify Hill‐frame delta-V and time drift
src/bsk_rl/act/continuous_actions.py New ImpulsiveThrustHill subclass converting Hill-frame thrust to inertial
src/bsk_rl/act/init.py Registered ImpulsiveThrustHill and updated import/export list
docs/source/release_notes.rst Documented new ImpulsiveThrustHill feature in release notes

Comment thread docs/source/release_notes.rst Outdated

@dhutererprats dhutererprats left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@Mark2000
Mark2000 force-pushed the feature/144-hill-frame-thrust branch from e298b66 to bc6242c Compare June 12, 2025 19:35
@Mark2000
Mark2000 merged commit 4d9fe77 into develop Jun 12, 2025
5 checks passed
@Mark2000
Mark2000 deleted the feature/144-hill-frame-thrust branch June 12, 2025 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants