[#144] Correct noncircular orbit generation

[Mark2000]

Description

Separate :class:random_circular_orbit and :class:random_orbit to avoid misleading
altitude argument.

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

How should this pull request be reviewed?

• By commit
• All changes at once

How Has This Been Tested?

Updated tests.

Checklist

• I have performed a self-review of my code
• I have commented my code in hard-to-understand areas
• I have made corresponding changes to the documentation and release notes
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works

[Copilot]

Pull Request Overview

This PR separates the generation of circular orbits from noncircular ones to avoid confusion around the altitude argument and introduces the new function random_circular_orbit.

• Added tests for random_circular_orbit and updated tests to use the new parameter a instead of alt.
• Updated the random_orbit API in src/bsk_rl/utils/orbital.py to handle the deprecated alt and r_body parameters.
• Updated documentation and release notes accordingly.

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
tests/unittest/utils/test_orbital.py	Added and updated tests to include random_circular_orbit.
tests/integration/obs/test_int_relative_observations.py	Updated random_orbit calls to use parameter a instead of alt.
tests/integration/obs/test_int_observations.py	Updated random_orbit call to use new API parameter naming.
tests/integration/act/test_int_actions_discrete.py	Updated random_orbit call to use parameter a instead of alt.
src/bsk_rl/utils/orbital.py	Modified API and implementation for separating orbit types.
docs/source/release_notes.rst	Updated release notes to reflect the new orbit generation API.

[dhutererprats]

make r_body optional argument, so one can create a random orbit with just setting altitude

[dhutererprats]

Also, I am seeing that we don't treat Omega and omega any differently in the random_orbit function when inclination is exactly i=0.0. Shouldn't we have some sort of reference, usually vernal equinox or so, to define the orbital elements of such an equatorial orbit?

[Mark2000]

I think that's outside the scope of this issue, since we just inherit behavior from Basilisk for the oe to rv conversion. I think its up to the user to consider picking sensible observations, etc if they are using degenerate orbits.

[Mark2000]

Ah, I think I see what the confusion is coming from. Optional[Type] is just a type hint alias for Union[None, Type]. The argument was already optional in the sense that it has a default value, but we never expect that value to be None.

[dhutererprats]

Looks good to me.