[MINOR] Make deorbit radius configurable#321
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the altitude validation check to use a configurable minimum orbital radius parameter instead of a hardcoded value, improving flexibility for different mission scenarios.
- Adds
min_orbital_radiusparameter tosetup_spacecraft_hubwith default value matching the previous hardcoded limit (200km above Earth's surface) - Stores the minimum orbital radius as an instance variable for use in validation
- Updates
altitude_validmethod to use the configurable parameter
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ba46e29 to
fb75bf6
Compare
fb75bf6 to
c4b11f1
Compare
Yume27
approved these changes
Nov 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds deorbit radius to sat args
Type of change
How should this pull request be reviewed?
How Has This Been Tested?
Covered by tests.
Future Work
None.
Checklist