Skip to content

[MINOR] Make deorbit radius configurable#321

Merged
Mark2000 merged 1 commit into
developfrom
feature/deorbit-radius
Nov 5, 2025
Merged

[MINOR] Make deorbit radius configurable#321
Mark2000 merged 1 commit into
developfrom
feature/deorbit-radius

Conversation

@Mark2000

@Mark2000 Mark2000 commented Nov 4, 2025

Copy link
Copy Markdown
Contributor

Description

Adds deorbit radius to sat args

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How should this pull request be reviewed?

  • By commit
  • All changes at once

How Has This Been Tested?

Covered by tests.

Future Work

None.

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation and release notes
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@Mark2000 Mark2000 marked this pull request as ready for review November 4, 2025 17:34
Copilot AI review requested due to automatic review settings November 4, 2025 17:34

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the altitude validation check to use a configurable minimum orbital radius parameter instead of a hardcoded value, improving flexibility for different mission scenarios.

  • Adds min_orbital_radius parameter to setup_spacecraft_hub with default value matching the previous hardcoded limit (200km above Earth's surface)
  • Stores the minimum orbital radius as an instance variable for use in validation
  • Updates altitude_valid method to use the configurable parameter

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/bsk_rl/sim/dyn/base.py Outdated
Comment thread src/bsk_rl/sim/dyn/base.py Outdated
@Mark2000 Mark2000 force-pushed the feature/deorbit-radius branch from ba46e29 to fb75bf6 Compare November 4, 2025 17:44
@Mark2000 Mark2000 force-pushed the feature/deorbit-radius branch from fb75bf6 to c4b11f1 Compare November 4, 2025 18:24
@Yume27 Yume27 self-requested a review November 5, 2025 16:40
@Mark2000 Mark2000 merged commit 39d4b45 into develop Nov 5, 2025
7 checks passed
@Mark2000 Mark2000 deleted the feature/deorbit-radius branch November 5, 2025 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants