Skip to content

Bug/fix test attitude setpoint test#336

Merged
LorenzzoQM merged 2 commits into
developfrom
bug/fix_TestAttitudeSetpoint_test
Mar 9, 2026
Merged

Bug/fix test attitude setpoint test#336
LorenzzoQM merged 2 commits into
developfrom
bug/fix_TestAttitudeSetpoint_test

Conversation

@LorenzzoQM

Copy link
Copy Markdown
Contributor

Description

Closes #335
Relax TestAttitudeSetpoint test tolerance to avoid eventual failures due to random initial conditions.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How should this pull request be reviewed?

  • By commit
  • All changes at once

How Has This Been Tested?

Tests passed (multiple times).

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation and release notes
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@LorenzzoQM LorenzzoQM self-assigned this Mar 9, 2026
Copilot AI review requested due to automatic review settings March 9, 2026 17:39

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses intermittent failures in the TestAttitudeSetpoint integration test caused by randomized initial conditions, aiming to make the test more robust and less flaky.

Changes:

  • Repeat TestAttitudeSetpoint multiple times to exercise randomized initial conditions.
  • Adjust the attitude setpoint action configuration and relax the assertion tolerance.
  • Document the test robustness change in the development release notes.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
tests/integration/act/test_int_actions_continuous.py Makes TestAttitudeSetpoint more robust by repeating runs, adjusting control_period, and loosening the comparison tolerance.
docs/source/release_notes.rst Adds a release note entry describing the test tolerance relaxation.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tests/integration/act/test_int_actions_continuous.py Outdated
Comment thread docs/source/release_notes.rst Outdated
@LorenzzoQM LorenzzoQM force-pushed the bug/fix_TestAttitudeSetpoint_test branch from ebb51f8 to f42cbac Compare March 9, 2026 17:46
@LorenzzoQM LorenzzoQM requested a review from Mark2000 March 9, 2026 17:49

@Mark2000 Mark2000 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good.

@LorenzzoQM LorenzzoQM merged commit a0b70f1 into develop Mar 9, 2026
7 checks passed
@LorenzzoQM LorenzzoQM deleted the bug/fix_TestAttitudeSetpoint_test branch March 9, 2026 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Test TestAttitudeSetpoint fails due to tight tolerance

3 participants