Bug/fix test attitude setpoint test#336
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses intermittent failures in the TestAttitudeSetpoint integration test caused by randomized initial conditions, aiming to make the test more robust and less flaky.
Changes:
- Repeat
TestAttitudeSetpointmultiple times to exercise randomized initial conditions. - Adjust the attitude setpoint action configuration and relax the assertion tolerance.
- Document the test robustness change in the development release notes.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
tests/integration/act/test_int_actions_continuous.py |
Makes TestAttitudeSetpoint more robust by repeating runs, adjusting control_period, and loosening the comparison tolerance. |
docs/source/release_notes.rst |
Adds a release note entry describing the test tolerance relaxation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ebb51f8 to
f42cbac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #335
Relax TestAttitudeSetpoint test tolerance to avoid eventual failures due to random initial conditions.
Type of change
How should this pull request be reviewed?
How Has This Been Tested?
Tests passed (multiple times).
Checklist