Skip to content

Fix bsk-sdk wheel packaging#9

Merged
ReeceHumphreys merged 10 commits into
developfrom
fix/wheels
May 5, 2026
Merged

Fix bsk-sdk wheel packaging#9
ReeceHumphreys merged 10 commits into
developfrom
fix/wheels

Conversation

@ReeceHumphreys

@ReeceHumphreys ReeceHumphreys commented Apr 29, 2026 •
edited by schaubh
Loading

Copy link
Copy Markdown
Collaborator
  • Switched to source-only wheel since the previous wheel shipped Linux-compiled .a static libraries tagged as platform-neutral,. This was unusable on macOS and Windows.
  • Pinned SWIG to epoch 5 (==4.4.1)
  • Fixed SWIG mismatch error message
  • Fixed bsk version check
  • Switched CI to Basilisk nightly wheels instead of pinning to a PyPI release.
  • Extracted wheel build into a reusable composite action
  • CI now clones Basilisk directly at the release tag

ReeceHumphreys added a commit that referenced this pull request Apr 29, 2026
@ReeceHumphreys
[#9] Pin SWIG to epoch 4 (<4.4.0)
ac4e23d
ReeceHumphreys added a commit that referenced this pull request Apr 29, 2026
@ReeceHumphreys
[#9] Ship SDK as source-only py3-none-any wheel
dc7444e
ReeceHumphreys added a commit that referenced this pull request Apr 29, 2026
@ReeceHumphreys
[#9] Compile SDK sources into plugin at build time
5cb52a2
ReeceHumphreys added a commit that referenced this pull request Apr 29, 2026
@ReeceHumphreys
[#9] Fix message targets, smoke tests, and example for source-only SDK
5fb9074
ReeceHumphreys added a commit that referenced this pull request Apr 29, 2026
@ReeceHumphreys
[#9] Extract wheel build into reusable composite action
d36d0a2
ReeceHumphreys added a commit that referenced this pull request Apr 29, 2026
@ReeceHumphreys
[#9] Use Basilisk nightly wheels in CI example build
2cf1927
ReeceHumphreys added a commit that referenced this pull request Apr 29, 2026
@ReeceHumphreys
[#9] Warn on pre-release bsk version mismatch, error on stable
29558b5
ReeceHumphreys added a commit that referenced this pull request Apr 29, 2026
@ReeceHumphreys
[#9] Clone Basilisk directly at tag instead of via submodule
90bb5d7
@schaubh

schaubh commented Apr 29, 2026

Copy link
Copy Markdown
Contributor

@codex review

chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed Apr 29, 2026
View reviewed changes

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 235441af33

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread cmake/bsk-sdkConfig.cmake.in
Comment thread .github/workflows/ci.yml
@ReeceHumphreys ReeceHumphreys self-assigned this Apr 29, 2026
@ReeceHumphreys ReeceHumphreys added the bug Something isn't working label Apr 29, 2026
@ReeceHumphreys ReeceHumphreys moved this to 👀 In review in Basilisk Apr 29, 2026
schaubh
schaubh requested changes Apr 29, 2026
View reviewed changes
Comment thread pyproject.toml Outdated
Comment thread .github/workflows/publish-wheels.yml
Comment thread examples/custom-atm-plugin/pyproject.toml Outdated
Comment thread pyproject.toml Outdated
Comment thread cmake/bsk_add_swig_module.cmake
Comment thread .github/workflows/ci.yml Outdated
ReeceHumphreys added a commit that referenced this pull request May 3, 2026
@ReeceHumphreys
[#9] Address Pin SWIG to 4.4.1 and update CI step name
d30dfba
@ReeceHumphreys ReeceHumphreys enabled auto-merge (rebase) May 4, 2026 01:11
schaubh
schaubh approved these changes May 5, 2026
View reviewed changes

@schaubh schaubh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go.

@ReeceHumphreys ReeceHumphreys merged commit a3bab9e into develop May 5, 2026
18 checks passed
ReeceHumphreys added a commit that referenced this pull request May 5, 2026
@ReeceHumphreys
[#9] Require SWIG epoch 5 (>=4.4.1)
3c74836
ReeceHumphreys added a commit that referenced this pull request May 5, 2026
@ReeceHumphreys
[#9] Ship SDK as source-only py3-none-any wheel
9c28a2a
@ReeceHumphreys ReeceHumphreys deleted the fix/wheels branch May 5, 2026 02:07
ReeceHumphreys added a commit that referenced this pull request May 5, 2026
@ReeceHumphreys
[#9] Fix message targets, smoke tests, and example for source-only SDK
1408e44
ReeceHumphreys added a commit that referenced this pull request May 5, 2026
@ReeceHumphreys
[#9] Extract wheel build into reusable composite action
e57fc5b
ReeceHumphreys added a commit that referenced this pull request May 5, 2026
@ReeceHumphreys
[#9] Warn on pre-release bsk version mismatch, error on stable
8893c35
ReeceHumphreys added a commit that referenced this pull request May 5, 2026
@ReeceHumphreys
[#9] Clone Basilisk directly at tag instead of via submodule
59179d4
ReeceHumphreys added a commit that referenced this pull request May 5, 2026
@ReeceHumphreys
[#9] Build Basilisk from patch/v2_10_x in CI and bump version to 2.10.1
5b2450d
ReeceHumphreys added a commit that referenced this pull request May 5, 2026
@ReeceHumphreys
[#9] Always compile SDK sources into plugin regardless of LINK_LIBS; …
0d7a978 
…fix README
ReeceHumphreys added a commit that referenced this pull request May 5, 2026
@ReeceHumphreys
[#9] Fix pip local install path for Basilisk source dir
ae40580
@github-project-automation github-project-automation Bot moved this from 👀 In review to ✅ Done in Basilisk May 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments
@schaubh schaubh schaubh approved these changes

Assignees

@ReeceHumphreys ReeceHumphreys

Labels

bug Something isn't working

Projects

Basilisk
Status: ✅ Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ReeceHumphreys @schaubh