Implemented tag compatibility#1230
Open
sararimuro wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the PR
Plugin now fetches submission tags set by the grader from api endpoints submissiondata/me and submissions/{id}. Tags arrive in different formats from both endpoints, so they had to be formatted separately. Some changes were also implemented to the logic behind finding the best submission: as the api id for the best submission only considers highest points, the plugin builds on that by taking tags into account and will test if there exists a submission with better points and no "warn" tag set, always preferring them over the tagged ones.
I have tested new changed by testing it with different combinations of submissions both on the live 2025 and local course version. Due to the fact that the live version of A+ does not currently support tags on the submissiondata path, I had to test it locally and I tested the submissions/{id} path globally. The tests were manual and involved different combinations of assignments with missing points, full points, errors, tags set and not. As I had to test both paths on different servers, some small errors might occur, but I tried to be as meticulous with my tests as I could.
Note that if you want to test these changes, you might want to use the A+ image at mxkaj/run-aplus-front:1.29-v1, since the current one (as of 24.7.2025) does not provide tags on the submissiondata path.