Merge pull request #1 from Abhijeet2409/fix-gfi-notification

Fix gfi notification

Author: Abhijeet2409

.github/scripts/bot-gfi-assign-on-comment.js

@@ -146,28 +146,40 @@ async function isRepoCollaborator({ github, owner, repo, username }) {
     }
 
     try {
-        await github.rest.repos.checkCollaborator({
+        const response = await github.rest.repos.getCollaboratorPermissionLevel({
             owner,
             repo,
             username,
         });
-        return true; // 204 = collaborator
+
+        const permission = response?.data?.permission;
+
+        const isTeamMember =
+            permission === 'admin' ||
+            permission === 'write' ||
+            permission === 'read';
+
+        console.log('[gfi-assign] isRepoCollaborator:', {
+            username,
+            permission,
+            isTeamMember,
+        });
+
+        return isTeamMember;
     } catch (error) {
-        if (error?.status === 404 || isPermissionFailure(error)) {
-            if (isPermissionFailure(error)) {
-                console.log(
-                    '[gfi-assign] isRepoCollaborator: insufficient permissions; treating as non-collaborator',
-                    { owner, repo, username, status: error.status }
-                );
-            }
+        if (isPermissionFailure(error) || error?.status === 404) {
+            console.log(
+                '[gfi-assign] isRepoCollaborator: no permission / not collaborator',
+                { username, status: error.status }
+            );
             return false;
         }
-        throw error; // unexpected error
+        throw error;
     }
-
 }
 
 
+
 /// START OF SCRIPT ///
 module.exports = async ({ github, context }) => {
     try {
@@ -221,6 +233,8 @@ module.exports = async ({ github, context }) => {
                 });
 
                 if (isTeamMember) {
+                        // Team members comment for discussion, not assignment.
+                        // Do not send /assign reminders to collaborators.
                     console.log('[gfi-assign] Skip reminder: commenter is collaborator');
                     return;
                 }

CHANGELOG.md

@@ -205,6 +205,7 @@ This changelog is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.
 - Update changelog workflow to trigger automatically on pull requests instead of manual dispatch (#1567)
 
 ### Fixed
+- Ensured that the GFI assignment bot skips posting `/assign` reminders for repository collaborators to avoid unnecessary notifications.(#1568).
 - Reduced notification spam by skipping the entire advanced qualification job for non-advanced issues and irrelevant events (#1517)
 - Aligned token freeze example filename references and improved error handling by catching broader exceptions with clearer messages. (#1412)
 - Fixed jq syntax in bot-office-hours.sh (#1502)