Consolidate glTF PBR graph and remove GLSL override#2850
Merged
jstone-lucasfilm merged 1 commit intoAcademySoftwareFoundation:mainfrom Apr 9, 2026
Merged
Conversation
This changelist consolidates the dielectric iridescence path in the glTF PBR shading graph, and removes the hand-authored GLSL graph override that is no longer needed. The following specific changes are included: - Restructure the dielectric iridescence path from `mix(layer(A, C), layer(B, C), w)` to `layer(mix(A, B, w), C)`, eliminating a duplicated layer node that was a workaround for earlier codegen limitations. - Remove the hand-authored GLSL graph override for `gltf_pbr`, as the `PremultipliedBsdfAddRefactor` pass now reproduces these optimizations automatically from the consolidated global graph.
Member
Author
|
I'm attaching render comparisons of two glTF PBR example materials, before and after the current PR, demonstrating that both visuals and performance are unchanged: glTF PBR Carpaint (Before): 
glTF PBR Carpaint (After): 
glTF PBR Glass (Before): 
glTF PBR Glass (After): 
|
Member
Author
niklasharrysson
approved these changes
Apr 8, 2026
Contributor
niklasharrysson
left a comment
niklasharrysson
left a comment
There was a problem hiding this comment.
This looks good to me. Nice to get rid of that limitation!
kwokcb
approved these changes
Apr 9, 2026
Contributor
kwokcb
left a comment
kwokcb
left a comment
There was a problem hiding this comment.
This looks good to me as well.
Contributor
|
Great find, looks good to me. |
jstone-lucasfilm
merged commit e5b1831
into
AcademySoftwareFoundation:main
36 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changelist consolidates the dielectric iridescence path in the glTF PBR shading graph, and removes the hand-authored GLSL graph override that is no longer needed. The following specific changes are included:
mix(layer(A, C), layer(B, C), w)tolayer(mix(A, B, w), C), eliminating a duplicated layer node that was a workaround for earlier codegen limitations.gltf_pbr, as thePremultipliedBsdfAddRefactorpass now reproduces these optimizations automatically from the consolidated global graph.