Load extraLibraryPaths before standard libraries in test suite#2875
Closed
ppenenko wants to merge 1 commit intoAcademySoftwareFoundation:mainfrom
Closed
Load extraLibraryPaths before standard libraries in test suite#2875ppenenko wants to merge 1 commit intoAcademySoftwareFoundation:mainfrom
ppenenko wants to merge 1 commit intoAcademySoftwareFoundation:mainfrom
Conversation
Change the library loading order in MaterialXTest to load extra libraries before standard libraries, matching the behavior of MaterialXView and MaterialXGraphEditor where --library paths take precedence. This allows extraLibraryPaths to provide override implementations for standard MaterialX nodes. NodeDef::getImplementation() returns the first matching target based on document insertion order, so loading overrides first ensures they are selected. Also registers extraLibraryPaths and libraries/pbrlib/genglsl as source code search paths so that override implementations can #include standard library source files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Change the library loading order in MaterialXTest to load extra libraries before standard libraries, matching the behavior of MaterialXView and MaterialXGraphEditor where
--librarypaths take precedence.This allows
extraLibraryPathsto provide override implementations for standard MaterialX nodes.NodeDef::getImplementation()returns the first matching target based on document insertion order, so loading overrides first ensures they are selected.Changes
extraLibraryPathsbeforemx::loadLibraries({ "libraries" }, ...)inloadDependentLibraries()extraLibraryPathsandlibraries/pbrlib/genglslas source code search paths so that override implementations can#includestandard library source filesMotivation
MaterialXView already loads user-specified libraries first:
The test suite should have the same behavior to enable testing of custom node implementations that override standard nodes.
Test plan