Skip to content

Add specification proposal for maxcomponent and mincomponent nodes#2876

Merged
jstone-lucasfilm merged 1 commit intoAcademySoftwareFoundation:mainfrom
chinmaychahar:feature/maxcomponent-mincomponent-proposal
Apr 29, 2026
Merged

Add specification proposal for maxcomponent and mincomponent nodes#2876
jstone-lucasfilm merged 1 commit intoAcademySoftwareFoundation:mainfrom
chinmaychahar:feature/maxcomponent-mincomponent-proposal

Conversation

@chinmaychahar
Copy link
Copy Markdown
Contributor

@chinmaychahar chinmaychahar commented Apr 29, 2026

Summary

Add specification proposal for maxcomponent and mincomponent nodes to the Math Nodes section of the Specification Proposals document.

Closes #2802

Description

Per the discussion in #2802 with @jstone-lucasfilm :

  • These nodes support all vectorN and colorN types (vector2, vector3, vector4, color3,
    color4)
  • Output type is float

The proposal format follows existing nodes such as magnitude and dotproduct in the Standard Nodes document.

Use Cases

As mentioned in the issue, two places in the MaterialX data libraries currently use verbose 5-node patterns (3 extract + 2 max/min) that these nodes would simplify to a single node:

  1. Sheen intensity for glTF PBR (libraries/bxdf/gltf_pbr.mtlx) — uses maxcomponent pattern
  2. Absorption coefficient for OpenPBR Surface (libraries/bxdf/open_pbr_surface.mtlx) — uses mincomponent pattern

Scope

This PR addresses the specification proposal only. I can work on the follow-up implementation via graph definitions as a
separate PR once the proposal is reviewed and merged.

@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla Bot commented Apr 29, 2026

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: chinmaychahar / name: chinmaychahar (563157a)

@chinmaychahar chinmaychahar force-pushed the feature/maxcomponent-mincomponent-proposal branch from 45a7f93 to de2eabc Compare April 29, 2026 07:35
Signed-off-by: chinmaychahar <chinmay.cc.06@gmail.com>
Copy link
Copy Markdown
Member

@jstone-lucasfilm jstone-lucasfilm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, @chinmaychahar, and this proposal looks good to me!

@chinmaychahar
Copy link
Copy Markdown
Contributor Author

Thanks @jstone-lucasfilm ! Should I proceed with the implementation on the same PR or would you prefer I open another one?

@jstone-lucasfilm
Copy link
Copy Markdown
Member

Let's merge this update to the proposals document, and you can then proceed with an implementation in a separate PR.

The update to the proposals document should be safe to include in our v1.39.5 release, which is currently in testing, while the actual graph definition of the node would likely land in our next release.

@jstone-lucasfilm jstone-lucasfilm merged commit 1c00ccd into AcademySoftwareFoundation:main Apr 29, 2026
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add specification proposal for maxcomponent and mincomponent nodes

2 participants