Add specification proposal for maxcomponent and mincomponent nodes#2876
Merged
jstone-lucasfilm merged 1 commit intoAcademySoftwareFoundation:mainfrom Apr 29, 2026
Conversation
|
|
45a7f93 to
de2eabc
Compare
Signed-off-by: chinmaychahar <chinmay.cc.06@gmail.com>
de2eabc to
563157a
Compare
jstone-lucasfilm
approved these changes
Apr 29, 2026
Member
jstone-lucasfilm
left a comment
There was a problem hiding this comment.
Great work, @chinmaychahar, and this proposal looks good to me!
Contributor
Author
|
Thanks @jstone-lucasfilm ! Should I proceed with the implementation on the same PR or would you prefer I open another one? |
Member
|
Let's merge this update to the proposals document, and you can then proceed with an implementation in a separate PR. The update to the proposals document should be safe to include in our v1.39.5 release, which is currently in testing, while the actual graph definition of the node would likely land in our next release. |
1c00ccd
into
AcademySoftwareFoundation:main
36 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add specification proposal for
maxcomponentandmincomponentnodes to the Math Nodes section of the Specification Proposals document.Closes #2802
Description
Per the discussion in #2802 with @jstone-lucasfilm :
vector2,vector3,vector4,color3,color4)The proposal format follows existing nodes such as
magnitudeanddotproductin the Standard Nodes document.Use Cases
As mentioned in the issue, two places in the MaterialX data libraries currently use verbose 5-node patterns (3
extract+ 2max/min) that these nodes would simplify to a single node:libraries/bxdf/gltf_pbr.mtlx) — usesmaxcomponentpatternlibraries/bxdf/open_pbr_surface.mtlx) — usesmincomponentpatternScope
This PR addresses the specification proposal only. I can work on the follow-up implementation via graph definitions as a
separate PR once the proposal is reviewed and merged.