Fix 1.38 interface-bound input upgrade#2968
Merged
jstone-lucasfilm merged 4 commits intoJun 12, 2026
Merged
Conversation
MaterialX 1.39 validates node inputs as having exactly one binding. 1.38 nodegraph implementations allowed having a default value and an interfacename on implementation inputs. During the 1.38 to 1.39 upgrade we remove the stale value if connection is present.
jstone-lucasfilm
approved these changes
Jun 12, 2026
jstone-lucasfilm
left a comment
jstone-lucasfilm
left a comment
Member
There was a problem hiding this comment.
This looks like a correct fix to me, thanks @tdavidovicNV!
jstone-lucasfilm
changed the title
jstone-lucasfilm
merged commit ec7347b
into
AcademySoftwareFoundation:main
36 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MaterialX 1.39 validates node inputs as having exactly one binding. 1.38 nodegraph implementations allowed having a default value and an interfacename on implementation inputs. During the 1.38 to 1.39 upgrade we remove the stale value if connection is present.
(This is needed to use some of our Houdini 19.5 assets with MaterialX 1.39)