Validate glTF data in CgltfLoader#2975
Merged
jstone-lucasfilm merged 1 commit intoJun 17, 2026
Merged
Conversation
This changelist adds a `cgltf_validate` step to `CgltfLoader`, rejecting invalid glTF files before their contents are used to construct meshes. The cgltf parser is intentionally permissive, and does not verify that accessor ranges, buffer view extents, and object references are internally consistent. Validating the parsed data after buffer loading guards downstream mesh construction code against out-of-bounds reads when an invalid asset is loaded. This changelist additionally fixes a memory leak in `CgltfLoader`, where a failure in buffer loading or validation would previously return without freeing the data allocated by `cgltf_parse_file`.
kwokcb
approved these changes
Jun 17, 2026
kwokcb
left a comment
kwokcb
left a comment
Contributor
There was a problem hiding this comment.
This looks good to me.
BTW, I noticed that `GeometryHandler::loadGeometry() which calls this method has a return code which is not checked in for GLSL, MSL, Slang (all copied code I assume).
Member
Author
|
Good point, @kwokcb, and we should indeed add proper error reporting to our render test suite in a future PR. For now, this means that the render test suite will silently render empty images rather than reporting invalid meshes, which isn't ideal. |
jstone-lucasfilm
merged commit 7e7830e
into
AcademySoftwareFoundation:main
36 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changelist adds a
cgltf_validatestep toCgltfLoader, rejecting invalid glTF files before their contents are used to construct meshes.The cgltf parser is intentionally permissive, and does not verify that accessor ranges, buffer view extents, and object references are internally consistent. Validating the parsed data after buffer loading guards downstream mesh construction code against out-of-bounds reads when an invalid asset is loaded.
This changelist additionally fixes a memory leak in
CgltfLoader, where a failure in buffer loading or validation would previously return without freeing the data allocated bycgltf_parse_file.