Skip to content

Adsk Contrib - Hue curve python binding was not copying all parameters #2276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
doug-walker merged 4 commits into from
Apr 3, 2026
Merged

Adsk Contrib - Hue curve python binding was not copying all parameters #2276

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
062eb55
Fix bug in hue curve python binding
doug-walker Mar 19, 2026
6315d88
Pointer check improvement
doug-walker Mar 27, 2026
0667d33
Dangling reference fix
doug-walker Apr 3, 2026
9ae059c
Merge branch 'main' into walker/hue-issue
doug-walker Apr 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/OpenColorIO/fileformats/ctf/CTFReaderHelper.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -862,11 +862,11 @@ void CTFReaderDescElt::start(const char ** atttributes )
m_language = {};

const char ** attr = atttributes;
while (*attr)
while (attr && *attr)
Comment thread
doug-walker marked this conversation as resolved.
Outdated
{
if (0 == Platform::Strcasecmp(ATTR_LANGUAGE, *attr))
{
if (!attr || !(attr + 1))
if (!(attr + 1) || !*(attr + 1))
Comment thread
remia marked this conversation as resolved.
Outdated
Comment thread
doug-walker marked this conversation as resolved.
Outdated
{
throwMessage("Attribute 'language' does not have a value.");
}
Expand Down
3 changes: 3 additions & 0 deletions src/bindings/python/PyGradingData.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,14 @@ using GradingControlPointIterator = PyIterator<GradingBSplineCurveRcPtr, IT_CONT

void CopyGradingBSpline(GradingBSplineCurveRcPtr to, const ConstGradingBSplineCurveRcPtr from)
{
to->setSplineType(from->getSplineType());

const size_t numPt = from->getNumControlPoints();
to->setNumControlPoints(numPt);
for (size_t pt = 0; pt < numPt; ++pt)
{
to->getControlPoint(pt) = from->getControlPoint(pt);
to->setSlope(pt, from->getSlope(pt));
}
}

Expand Down
23 changes: 23 additions & 0 deletions tests/python/GradingDataTest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,6 +368,29 @@ def test_huecurve(self):
assertEqualBSpline(self, hcrv.lum_sat, ls)
self.assertEqual(hcrv.lum_sat, ls)

# Check that setting the hue curve preserves the spline type.
hcrv.hue_sat = ls
ls2 = hcrv.hue_sat
# Spline type is now different than what hue_sat normally uses (PERIODIC_1_B_SPLINE).
self.assertEqual(ls2.getSplineType(), OCIO.HORIZONTAL1_B_SPLINE)
self.assertEqual(hcrv.hue_sat, ls)
self.assertEqual(ls2, ls)

# Check that setting the hue curve preserves the slopes.
self.assertEqual(ls.slopesAreDefault(), True)
slopes = ls.getSlopes()
slopes[1] = 0.5
ls.setSlopes(slopes)
self.assertEqual(ls.slopesAreDefault(), False)
hcrv.hue_sat = ls
ls2 = hcrv.hue_sat
self.assertEqual(ls2.slopesAreDefault(), False)
slopes2 = ls2.getSlopes()
self.assertEqual(slopes2[1], 0.5)
self.assertEqual(slopes2, slopes)
self.assertEqual(hcrv.hue_sat, ls)
self.assertEqual(ls2, ls)

def test_rgbmsw(self):
"""
Test the GradingRGBMSW struct.
Expand Down
Loading