[cuebot/cuegui] Feature add layer dispatchorder control#2354
Open
tifilipebr wants to merge 11 commits into
Open
[cuebot/cuegui] Feature add layer dispatchorder control#2354tifilipebr wants to merge 11 commits into
tifilipebr wants to merge 11 commits into
Conversation
…2034) ASWF created a discussion group to come up with a process to release binaries. While this effort is ongoing, we were advised to avoid publishing binaries on github when possible.
- Allow multi selection
Signed-off-by: Alexis Oblet <alexis@theyard-vfx.com>
Signed-off-by: Alexis Oblet <aoblet@users.noreply.github.com>
- remove unused `reorder_dispatch_action` variable ref: https://github.com/AcademySoftwareFoundation/OpenCue/actions/runs/23460615965/job/68261240038?pr=2226
tifilipebr
requested review from
DiegoTavares,
lithorus and
ramonfigueiredo
as code owners
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThis PR adds SetDispatchOrder across the stack: proto RPC/messages, Java backend DAO/service and JDBC persistence with validation, ManageLayer gRPC handler, Python Layer wrapper, cuegui menu action, and a version bump to 1.24. ChangesLayer Dispatch Order Feature
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~22 minutes
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@cuebot/src/main/java/com/imageworks/spcue/dao/postgres/LayerDaoJdbc.java`:
- Around line 319-321: The validation in LayerDaoJdbc currently checks "if (val
< 0)" but the exception message says "must be positive," which is inconsistent;
update the check to "if (val <= 0)" so that the code enforces a strictly
positive dispatch order (keep the existing message), referencing the same val
variable in LayerDaoJdbc where the current check is performed.
In `@cuegui/cuegui/MenuActions.py`:
- Line 1093: The else branch sets title = "Reorder layer %s" % layer.data.name
but `layer` is undefined for the single-layer case; mirror the approach used in
the reorder method by assigning the first selected layer to a local variable
(e.g., __layer = layers[0]) and use __layer.data.name when building the title so
the single-layer path references a defined symbol (adjust in the method that
builds the title where `layer` is currently used).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: eb71a675-0162-4c46-897d-fea46dcef981
📒 Files selected for processing (10)
VERSION.incuebot/src/main/java/com/imageworks/spcue/dao/LayerDao.javacuebot/src/main/java/com/imageworks/spcue/dao/postgres/LayerDaoJdbc.javacuebot/src/main/java/com/imageworks/spcue/servant/ManageLayer.javacuebot/src/main/java/com/imageworks/spcue/service/JobManager.javacuebot/src/main/java/com/imageworks/spcue/service/JobManagerService.javacuegui/cuegui/LayerMonitorTree.pycuegui/cuegui/MenuActions.pyproto/src/job.protopycue/opencue/wrappers/layer.py
Contributor
There was a problem hiding this comment.
♻️ Duplicate comments (1)
cuegui/cuegui/MenuActions.py (1)
1093-1095:⚠️ Potential issue | 🔴 Critical | ⚡ Quick winFix undefined variable in single-layer reorder title (Line 1094).
layeris undefined in the single-layer branch, causing a runtimeNameErrorwhen this action is used with one selected layer.🐛 Proposed fix
- else: - title = "Reorder layer %s" % layer.data.name + else: + __layer = layers[0] + title = "Reorder layer %s" % __layer.data.name🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@cuegui/cuegui/MenuActions.py` around lines 1093 - 1095, The single-layer branch assigns title using an undefined variable "layer", causing a NameError; change that assignment to reference the actual selected-layer variable (e.g., use layers[0].data.name or the existing selected_layers/selectedLayer variable used elsewhere) so the line becomes something like title = "Reorder layer %s" % layers[0].data.name, ensuring you reference the same list/name used in the surrounding code where multiple layers are handled.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Duplicate comments:
In `@cuegui/cuegui/MenuActions.py`:
- Around line 1093-1095: The single-layer branch assigns title using an
undefined variable "layer", causing a NameError; change that assignment to
reference the actual selected-layer variable (e.g., use layers[0].data.name or
the existing selected_layers/selectedLayer variable used elsewhere) so the line
becomes something like title = "Reorder layer %s" % layers[0].data.name,
ensuring you reference the same list/name used in the surrounding code where
multiple layers are handled.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 7b8fe33c-515e-4d79-adef-8688c44021bb
📒 Files selected for processing (6)
VERSION.incuebot/src/main/java/com/imageworks/spcue/dao/postgres/LayerDaoJdbc.javacuegui/cuegui/LayerMonitorTree.pycuegui/cuegui/MenuActions.pyproto/src/job.protopycue/opencue/wrappers/layer.py
✅ Files skipped from review due to trivial changes (1)
- VERSION.in
Collaborator
|
Thanks, @tifilipebr. Please review and address the feedback from CodeRabbitAI first. Once all comments have been resolved, please mark them as Resolved. When your PR is ready for final review, just leave a comment in this PR and tag: @ramonfigueiredo We’ll review it and approve it as soon as possible. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR just complement it: #222
Summary by CodeRabbit
New Features
Chores