Add probe state and refactor Vulkan cleanup

Include pixel probe info in test state output and make Vulkan resource management more robust.

- imiv_developer_tools.cpp: Write probe fields (probe_valid, probe_pos, probe_channel_count) into the test-engine JSON output so runner tests can inspect probe state.
- imiv_image_view.cpp: Use env_read_int_value to fetch forced probe coordinates and simplify validation logic.
- imiv_vulkan_setup.cpp: Factor repeated destroy logic into small helper functions (shader module, pipeline, pipeline layout, descriptor set layout, descriptor pool, render pass) and use them across cleanup paths; change init_* functions to build resources in a linear, transactional manner (do-break cleanup) so partial failures clean up correctly; ensure shader modules are destroyed on failure and centralize descriptor pool destruction.
- tools/imiv_area_probe_closeup_regression.py: Add _run_runner helper and a two-step test flow: run a pixel-closeup probe to capture probe state JSON (validate probe_valid and probe_pos), then run the area-probe closeup runner. Also add probe_state_path and related checks.

These changes improve testability of the pixel probe feature and harden Vulkan resource lifecycle handling to avoid leaks on error paths.

Signed-off-by: Vlad <shaamaan@gmail.com>

Author: ssh4net

src/imiv/imiv_developer_tools.cpp

@@ -636,6 +636,13 @@ write_test_engine_viewer_state_json(const std::filesystem::path& out_path,
     test_engine_json_write_vec2(f, viewport_size);
     std::fputs(",\n  \"orientation\": ", f);
     std::fprintf(f, "%d", viewer.image.orientation);
+    std::fputs(",\n  \"probe_valid\": ", f);
+    std::fputs(viewer.probe_valid ? "true" : "false", f);
+    std::fputs(",\n  \"probe_pos\": [", f);
+    std::fprintf(f, "%d,%d", viewer.probe_x, viewer.probe_y);
+    std::fputs("]", f);
+    std::fputs(",\n  \"probe_channel_count\": ", f);
+    std::fprintf(f, "%zu", viewer.probe_channels.size());
     std::fputs(",\n  \"area_probe_lines\": [", f);
     for (size_t i = 0; i < viewer.area_probe_lines.size(); ++i) {
         if (i > 0)

src/imiv/imiv_image_view.cpp

@@ -26,14 +26,13 @@ namespace {
 
     bool apply_forced_probe_from_env(ViewerState& viewer)
     {
-        const int forced_x
-            = env_int_value_clamped("IMIV_IMGUI_TEST_ENGINE_PROBE_X", -1, 0,
-                                    1000000);
-        const int forced_y
-            = env_int_value_clamped("IMIV_IMGUI_TEST_ENGINE_PROBE_Y", -1, 0,
-                                    1000000);
-        if (forced_x < 0 || forced_y < 0 || viewer.image.path.empty())
+        int forced_x = -1;
+        int forced_y = -1;
+        if (!env_read_int_value("IMIV_IMGUI_TEST_ENGINE_PROBE_X", forced_x)
+            || !env_read_int_value("IMIV_IMGUI_TEST_ENGINE_PROBE_Y", forced_y)
+            || forced_x < 0 || forced_y < 0 || viewer.image.path.empty()) {
             return false;
+        }
 
         const int px = std::clamp(forced_x, 0,
                                   std::max(0, viewer.image.width - 1));