Skip to content

Commit 327fd6f

Browse files
committed
ci/deps: Freetype adjustments (#4999)
* CI test vs the latest freetype 2.14.1 * Bump the version of freetype that we auto-build to the latest (from 2.13.2) * Simplify BZip2 finding logic, switch to using targets Signed-off-by: Larry Gritz <lg@larrygritz.com>
1 parent ac8b61d commit 327fd6f

5 files changed

Lines changed: 8 additions & 10 deletions

File tree

.github/workflows/ci.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -435,7 +435,7 @@ jobs:
435435
PTEX_VERSION=v2.5.0
436436
PUGIXML_VERSION=v1.15
437437
WEBP_VERSION=v1.6.0
438-
FREETYPE_VERSION=VER-2-14-0
438+
FREETYPE_VERSION=VER-2-14-1
439439
USE_OPENVDB=0
440440
# Ensure we are testing all the deps we think we are. We would
441441
# like this test to have minimal missing dependencies.
@@ -520,7 +520,7 @@ jobs:
520520
PTEX_VERSION=v2.4.3
521521
PUGIXML_VERSION=v1.15
522522
WEBP_VERSION=v1.6.0
523-
FREETYPE_VERSION=VER-2-14-0
523+
FREETYPE_VERSION=VER-2-14-1
524524
USE_OPENVDB=0
525525
- desc: Linux ARM latest releases clang18 C++20 py3.12 exr3.4 ocio2.4
526526
nametag: linux-arm-latest-releases-clang
@@ -542,7 +542,7 @@ jobs:
542542
PTEX_VERSION=v2.4.3
543543
PUGIXML_VERSION=v1.15
544544
WEBP_VERSION=v1.6.0
545-
FREETYPE_VERSION=VER-2-14-0
545+
FREETYPE_VERSION=VER-2-14-1
546546
USE_OPENVDB=0
547547

548548
- desc: oldest gcc9/C++17 py3.9 exr3.1 ocio2.3

src/build-scripts/build_Freetype.bash

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ set -ex
1111

1212
# Repo and branch/tag/commit of Freetype to download if we don't have it yet
1313
FREETYPE_REPO=${FREETYPE_REPO:=https://github.com/freetype/freetype.git}
14-
FREETYPE_VERSION=${FREETYPE_VERSION:=VER-2-13-3}
14+
FREETYPE_VERSION=${FREETYPE_VERSION:=VER-2-14-1}
1515

1616
# Where to put Freetype repo source (default to the ext area)
1717
LOCAL_DEPS_DIR=${LOCAL_DEPS_DIR:=${PWD}/ext}

src/cmake/externalpackages.cmake

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -203,11 +203,9 @@ checked_find_package (R3DSDK NO_RECORD_NOTFOUND) # RED camera
203203
set (NUKE_VERSION "7.0" CACHE STRING "Nuke version to target")
204204
checked_find_package (Nuke NO_RECORD_NOTFOUND)
205205

206-
if (FFmpeg_FOUND OR FREETYPE_FOUND)
206+
if ((FFmpeg_FOUND OR FREETYPE_FOUND OR TARGET Freetype::Freetype)
207+
AND NOT TARGET BZip2::BZip2)
207208
checked_find_package (BZip2) # Used by ffmpeg and freetype
208-
if (NOT BZIP2_FOUND)
209-
set (BZIP2_LIBRARIES "") # TODO: why does it break without this?
210-
endif ()
211209
endif()
212210

213211

src/ffmpeg.imageio/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ if (FFmpeg_FOUND)
2828
add_oiio_plugin (ffmpeginput.cpp
2929
INCLUDE_DIRS ${FFMPEG_INCLUDES}
3030
LINK_LIBRARIES ${FFMPEG_LIBRARIES}
31-
${BZIP2_LIBRARIES}
31+
$<TARGET_NAME_IF_EXISTS:BZip2::BZip2>
3232
DEFINITIONS "USE_FFMPEG"
3333
"-DOIIO_FFMPEG_VERSION=\"${FFMPEG_VERSION}\"")
3434
else()

src/libOpenImageIO/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,7 @@ target_link_libraries (OpenImageIO
163163
$<TARGET_NAME_IF_EXISTS:pugixml::pugixml>
164164
$<TARGET_NAME_IF_EXISTS:TBB::tbb>
165165
$<TARGET_NAME_IF_EXISTS:Freetype::Freetype>
166-
${BZIP2_LIBRARIES}
166+
$<TARGET_NAME_IF_EXISTS:BZip2::BZip2>
167167
ZLIB::ZLIB
168168
${CMAKE_DL_LIBS}
169169
)

0 commit comments

Comments
 (0)