Skip to content

Commit a0426d6

Browse files
authored
testing: Adjust test comparision thresholds for Mac ARM (#5026)
Even though we have CI testing on Mac with ARM CPU that were passing, after getting a new laptop, I saw some test failures that were due to just a few pixels on a few tests needing a higher comparision threshold. Results are correct, just different due to the math. I guess this machine (CPU? build flags? specific compiler or library versions?) is ever so slightly different than the CI Macs, so I caught a few more instances that needed to be adjusted. I tried to increase the thresholds as little as possible to fix the problem. Signed-off-by: Larry Gritz <lg@larrygritz.com>
1 parent 9e7444a commit a0426d6

4 files changed

Lines changed: 4 additions & 0 deletions

File tree

testsuite/texture-crop/run.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
# SPDX-License-Identifier: Apache-2.0
55
# https://github.com/AcademySoftwareFoundation/OpenImageIO
66

7+
hardfail = 0.02
78

89
command += oiiotool("../common/grid.tif --crop 512x512+200+100 -o grid-crop.tif")
910
command += maketx_command ("grid-crop.tif", "grid-crop.tx")

testsuite/texture-interp-bilinear/run.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
# SPDX-License-Identifier: Apache-2.0
55
# https://github.com/AcademySoftwareFoundation/OpenImageIO
66

7+
hardfail = 0.02
78

89
command = testtex_command ("../common/textures/grid.tx",
910
extraargs = "-interpmode 1 -d uint8 -o out.tif")

testsuite/texture-skinny/run.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
# SPDX-License-Identifier: Apache-2.0
55
# https://github.com/AcademySoftwareFoundation/OpenImageIO
66

7+
hardfail = 0.013
78

89
command = testtex_command ("src/vertgrid.tx", " --scalest 4 1 ")
910
outputs = [ "out.exr" ]

testsuite/texture-uint8/run.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
# SPDX-License-Identifier: Apache-2.0
55
# https://github.com/AcademySoftwareFoundation/OpenImageIO
66

7+
hardfail = 0.021
78

89
command = testtex_command ("../common/textures/grid.tx")
910
outputs = [ "out.exr" ]

0 commit comments

Comments
 (0)