Skip to content

Commit a8d013c

Browse files
authored
fix: conform certain attrib names "exif:*" to our "Exif:*" convention (#5025)
I think it was basically harmless, since we do all the metadata name comparisons using case-insensitive comparisons. But we use "Exif:" as our prefix for Exif data throughout OIIO by convention, and there was this tiny handful of places where we said "exif:". Signed-off-by: Larry Gritz <lg@larrygritz.com>
1 parent a0426d6 commit a8d013c

2 files changed

Lines changed: 5 additions & 5 deletions

File tree

src/jpeg.imageio/jpegoutput.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -370,9 +370,9 @@ void
370370
JpgOutput::resmeta_to_density()
371371
{
372372
// Clear cruft from Exif that might confuse us
373-
m_spec.erase_attribute("exif:XResolution");
374-
m_spec.erase_attribute("exif:YResolution");
375-
m_spec.erase_attribute("exif:ResolutionUnit");
373+
m_spec.erase_attribute("Exif:XResolution");
374+
m_spec.erase_attribute("Exif:YResolution");
375+
m_spec.erase_attribute("Exif:ResolutionUnit");
376376

377377
string_view resunit = m_spec.get_string_attribute("ResolutionUnit");
378378
if (Strutil::iequals(resunit, "none"))

src/libOpenImageIO/xmp.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -98,8 +98,8 @@ static XMPtag xmptag[] = {
9898
{ "tiff:Software", "Software", TypeDesc::STRING, TiffRedundant },
9999

100100
{ "exif:ColorSpace", "Exif:ColorSpace", TypeDesc::INT, ExifRedundant },
101-
{ "exif:PixelXDimension", "", TypeDesc::INT, ExifRedundant|TiffRedundant},
102-
{ "exif:PixelYDimension", "", TypeDesc::INT, ExifRedundant|TiffRedundant },
101+
{ "exif:PixelXDimension", "Exif:PixelXDimension", TypeDesc::INT, ExifRedundant|TiffRedundant},
102+
{ "exif:PixelYDimension", "Exif:PixelYDimension", TypeDesc::INT, ExifRedundant|TiffRedundant },
103103
{ "exifEX:PhotographicSensitivity", "Exif:ISOSpeedRatings", TypeDesc::INT, ExifRedundant },
104104

105105
{ "xmp:CreateDate", "DateTime", TypeDesc::STRING, DateConversion|TiffRedundant },

0 commit comments

Comments
 (0)