Skip to content

Commit c5c8fb9

Browse files
authored
build: Bump auto-build libdeflate to 1.23 to avoid AVX512 not available errors (#4679)
When using `OpenImageIO_BUILD_LOCAL_DEPS` environment variable to build all OIIO's dependency locally, OIIO's build script specifies a set of default versions of the dependent libraries. In particular, `ebiggers/libdeflate` is set to `1.20`. This 1.20 version of libdeflate fails to build on platforms where AVX512 is not available and the make tool chain did not correctly tell the C compiler about it. ``` -- Building package TIFF locally -- Building package libdeflate locally -- Building local libdeflate 1.20 from https://github.com/ebiggers/libdeflate /usr/tmp/ccCelbo5.s: Assembler messages: /usr/tmp/ccCelbo5.s:649: Error: unsupported instruction `vpdpbusd' /usr/tmp/ccCelbo5.s:650: Error: unsupported instruction `vpdpbusd' ``` This issue is fixed in libdeflate Merge Request 389 ebiggers/libdeflate#389, by explicitly calling CMake facilities to detect whether AVX512 is present, and set compiler preprocessor flags accordingly in the cmake file. This libdeflate MR is after version 1.20. To fix OIIO's build error when building this dependency locally, one can either set `libdeflate_BUILD_VERSION` to include this patch, (for example `export libdeflate_BUILD_VERSION=1.23`) or change the default version in OIIO's local dependency build script to 1.23. This PR makes the change in OIIO's local dependency build script. Assembler build error resolved after using libdeflate v1.23 for local TIFF build. Signed-off-by: lji <lji@ilm.com>
1 parent 399ad82 commit c5c8fb9

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

src/cmake/build_libdeflate.cmake

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
# libdeflate by hand!
77
######################################################################
88

9-
set_cache (libdeflate_BUILD_VERSION 1.20 "libdeflate version for local builds")
9+
set_cache (libdeflate_BUILD_VERSION 1.23 "libdeflate version for local builds")
1010
set (libdeflate_GIT_REPOSITORY "https://github.com/ebiggers/libdeflate")
1111
set (libdeflate_GIT_TAG "v${libdeflate_BUILD_VERSION}")
1212
set_cache (libdeflate_BUILD_SHARED_LIBS OFF # ${LOCAL_BUILD_SHARED_LIBS_DEFAULT}

0 commit comments

Comments
 (0)