deps: use get_plane2 introduced by libheif 1.20.2#4851
Merged
lgritz merged 2 commits intoAug 7, 2025
Conversation
Signed-off-by: toge <toge.mail@gmail.com>
toge
force-pushed
the
follow-libheif-1_20_2
branch
from
8e5d71f to
2d3f8c1
Compare
lgritz
reviewed
Aug 7, 2025
lgritz
approved these changes
Aug 7, 2025
lgritz
left a comment
lgritz
left a comment
Collaborator
There was a problem hiding this comment.
LGTM! Thanks for the fix.
I tested it on my end as well -- and since on my laptop, Homebrew just upgraded to the new libheif which was broken, and this fixes it perfectly, I can verify directly that this is the right fix.
Co-authored-by: Larry Gritz <lg@larrygritz.com> Signed-off-by: toge <toge.mail@gmail.com>
Collaborator
|
Just out of curiosity, do you know why this was done on the libheif side? It looks like the old and new functions take the same arguments, so why make a new function and deprecate the old one instead of just changing the internal implementation of the one that existed? |
lgritz
added
the
build / testing / port / CI
lgritz
changed the title
Contributor
Author
|
@lgritz |
Collaborator
|
I'll do a backport immediately and a patch for 3.0.9.1 since people on Mac in particular might immediately run into this build break if they're getting their libheif dependency from Homebrew. |
lgritz
pushed a commit
to lgritz/OpenImageIO
that referenced
this pull request
Aug 7, 2025
…ndation#4851) libheif 1.20.2 introduces `get_plane2()` for compatibility. [ref](strukturag/libheif#1566) Because `get_plane()` has been marked as deprecated, we should use `get_plane2()` instead. --------- Signed-off-by: toge <toge.mail@gmail.com>
lgritz
pushed a commit
to lgritz/OpenImageIO
that referenced
this pull request
Sep 14, 2025
…ndation#4851) libheif 1.20.2 introduces `get_plane2()` for compatibility. [ref](strukturag/libheif#1566) Because `get_plane()` has been marked as deprecated, we should use `get_plane2()` instead. --------- Signed-off-by: toge <toge.mail@gmail.com>
lgritz
pushed a commit
to lgritz/OpenImageIO
that referenced
this pull request
Sep 15, 2025
…ndation#4851) libheif 1.20.2 introduces `get_plane2()` for compatibility. [ref](strukturag/libheif#1566) Because `get_plane()` has been marked as deprecated, we should use `get_plane2()` instead. --------- Signed-off-by: toge <toge.mail@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
libheif 1.20.2 introduces
get_plane2()for compatibility. refBecause
get_plane()has been marked as deprecated, we should useget_plane2()instead.Checklist:
need to update the documentation, for example if this is a bug fix that
doesn't change the API.)
(adding new test cases if necessary).
corresponding Python bindings (and if altering ImageBufAlgo functions, also
exposed the new functionality as oiiotool options).
already run clang-format before submitting, I definitely will look at the CI
test that runs clang-format and fix anything that it highlights as being
nonconforming.